fix(runtime): skip config reload when no admin_connector is configured - #9836
Open
cnbehr wants to merge 1 commit into
Open
fix(runtime): skip config reload when no admin_connector is configured#9836cnbehr wants to merge 1 commit into
admin_connector is configured#9836cnbehr wants to merge 1 commit into
Conversation
CreateInstance on a standalone runtime (rill runtime start, config reloader enabled, no admin connector) returned a 500 with 'unknown connector ""' because reloadConfig acquired the admin service unconditionally. The instance was actually created and functional, so the error was purely spurious. Skip the reload when inst.AdminConnector is empty, matching the guard runtime.go already applies before fetching cloud variables. Fixes rilldata#9832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateInstanceon a standalone runtime (rill runtime start, which enables the config reloader, without an admin connector) returns a 500 withunknown connector "":configReloader.reloadConfigacquires the admin service unconditionally, and the instance it just created has noadmin_connector. The instance is actually created and fully functional, so the error is purely spurious.inst.AdminConnector == "", matching the guardruntime.goalready applies before fetching cloud variables ("not configured only for tests").ReloadConfigis a clean no-op; it fails withunknown connector ""without the fix.Closes #9832
Checklist:
Developed in collaboration with Claude Code