fix(runtime): terminate fill-missing time spines for unaligned bounds - #9835
Open
eminemead wants to merge 1 commit into
Open
fix(runtime): terminate fill-missing time spines for unaligned bounds#9835eminemead wants to merge 1 commit into
eminemead wants to merge 1 commit into
Conversation
Generate a finite half-open bin list in timeutil, hard-capped at 1500, so looping OLAP dialects cannot hang or allocate unbounded SQL when start and end are not grain-aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectTimeRangeBinsin the starrocks, clickhouse, pinot, druid, and snowflake dialects looped forever when the truncated start never equalled an unaligned end (t != end), allocating unbounded SQL until the process was OOM-killed.timeutil.TimeRangeBinsnow truncates the start, iterates half-open witht.Before(end), and errors above 1500 actual bins. Those dialects only format that slice.ApproximateBinspre-check inast.gostays as a fast-fail.fillMissingrequest: HTTP 200 in under a second with flat memory (previously hung until timeout while resident memory grew to tens of GB).Checklist:
Developed in collaboration with Claude Code