Skip to content

fix: merge strategy is memory intensive #9054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-anshul merged 4 commits into from
Mar 16, 2026
Merged

fix: merge strategy is memory intensive #9054

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5438c15
fix: merge strategy is compute intensive
k-anshul Mar 13, 2026
b85488e
tables need drop now
k-anshul Mar 13, 2026
a56af84
use gracful ctx
k-anshul Mar 16, 2026
cd8c76e
review comments
k-anshul Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions runtime/drivers/duckdb/crud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ import (
"fmt"
"time"

"github.com/google/uuid"
"github.com/jmoiron/sqlx"
runtimev1 "github.com/rilldata/rill/proto/gen/rill/runtime/v1"
"github.com/rilldata/rill/runtime/drivers"
"github.com/rilldata/rill/runtime/pkg/graceful"
"github.com/rilldata/rill/runtime/pkg/rduckdb"
"go.uber.org/zap"
)

type tableWriteMetrics struct {
Expand Down Expand Up @@ -127,11 +128,19 @@ func (c *connection) insertTableAsSelect(ctx context.Context, name, sql string,
}

// Create a temporary table with the new data
tmp := uuid.New().String()
_, err := conn.ExecContext(ctx, fmt.Sprintf("CREATE TEMPORARY TABLE %s AS (%s\n)", safeSQLName(tmp), sql))
tmp := fmt.Sprintf("__rill_temp_%s", name)
_, err := conn.ExecContext(ctx, fmt.Sprintf("CREATE OR REPLACE TABLE %s AS (%s\n)", safeSQLName(tmp), sql))
if err != nil {
return err
}
defer func() {
bgctx, cancel := graceful.WithMinimumDuration(ctx, time.Second*10)
defer cancel()
_, err := conn.ExecContext(bgctx, fmt.Sprintf("DROP TABLE %s", safeSQLName(tmp)))
if err != nil {
c.logger.Warn("failed to drop temporary table", zap.Error(err))
}
}()

// check the count of the new data
// skip if the count is 0
Expand Down Expand Up @@ -188,11 +197,19 @@ func (c *connection) insertTableAsSelect(ctx context.Context, name, sql string,
}

// Create a temporary table with the new data
tmp := uuid.New().String()
_, err := conn.ExecContext(ctx, fmt.Sprintf("CREATE TEMPORARY TABLE %s AS (%s\n)", safeSQLName(tmp), sql))
tmp := fmt.Sprintf("__rill_temp_%s", name)
_, err := conn.ExecContext(ctx, fmt.Sprintf("CREATE OR REPLACE TABLE %s AS (%s\n)", safeSQLName(tmp), sql))
if err != nil {
return err
}
defer func() {
bgctx, cancel := graceful.WithMinimumDuration(ctx, time.Second*10)
defer cancel()
_, err := conn.ExecContext(bgctx, fmt.Sprintf("DROP TABLE %s", safeSQLName(tmp)))
if err != nil {
c.logger.Warn("failed to drop temporary table", zap.Error(err))
}
}()

// Check the count of the new data
// Skip if the count is 0
Expand Down
Loading