Upgrade to Svelte 5, bits-ui 2.x, and tanstack-table-8-svelte-5#9045
Draft
ericpgreen2 wants to merge 4 commits intomainfrom
Draft
Upgrade to Svelte 5, bits-ui 2.x, and tanstack-table-8-svelte-5#9045ericpgreen2 wants to merge 4 commits intomainfrom
ericpgreen2 wants to merge 4 commits intomainfrom
Conversation
- svelte ^4.2.19 → ^5.0.0 (all workspaces) - @sveltejs/vite-plugin-svelte override ^3.1.2 → ^4.0.0 - @tanstack/svelte-table → tanstack-table-8-svelte-5 (Svelte 5 compat) - bits-ui ^0.22.0 → ^2.14.4 (Svelte 5 required) - Remove cmdk-sv (replaced by bits-ui Command in next commit)
Step 2+3 of Svelte 5 upgrade: - Rewrite all bits-ui wrapper components for v2 API changes - Create Svelte 5 Trigger bridge wrappers (asChild → child snippet) - Migrate Select API: selected → value, onSelectedChange → onValueChange - Replace cmdk-sv with bits-ui Command components - Migrate on:event → onevent callback props on runes-mode wrappers - Remove deprecated props: transition, portal, fitViewport, typeahead, closeOnItemClick, CustomEventHandler, disableFocusFirstItem - Move onOutsideClick from Dialog.Root to onInteractOutside on Content - Replace RadioIndicator/CheckboxIndicator/ItemIndicator with CSS - Change Label → GroupHeading in select/dropdown/context menus - Convert TypeScript enums to const objects in .svelte files - Fix HTML validity: div inside tr → td, remove empty CSS declarations - Add missing peer deps: @internationalized/date, @tiptap/suggestion, vega-embed - Add npm overrides for svelte and @sveltejs/vite-plugin-svelte to resolve peer dep conflicts with storybook
…onent - Replace `new Component()` / `$set()` / `$destroy()` with `mount()` / `unmount()` / `$state` in create-placeholder and editor-plugins (renamed to .svelte.ts for rune support) - Use `renderComponent` instead of `flexRender` for custom cell components in PartitionsTable - Update imports in ChatInput, UserMessage, and MetricsEditor for renamed files
Replace `<span style="display:contents">` with `<div>` in dropdown menu, popover, tooltip, and context menu trigger wrappers. Elements with `display:contents` have no bounding rect, causing floating UI to position dropdowns at (0,0) instead of next to the trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sveltejs/vite-plugin-sveltev4@tanstack/svelte-tablewithtanstack-table-8-svelte-5(Svelte 5-compatible fork usingflexRender/renderComponent)bits-uifrom 0.22 to 2.x: rewrite wrapper components (asChild→childsnippet bridge,Selectedtype removal,on:event→onclick, transitions removed)cmdk-svwith bits-ui's built-inCommandcomponentcomponent_api_invalid_new(new Component()→mount()/unmount()),$set()→$statereactive props, TypeScript enums → const objects, self-closing HTML tags,display:contentstrigger wrappers →<div>for floating UI positioningTODO:
Checklist:
Developed in collaboration with Claude Code