Skip to content

Make as of clause sticky #9015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nishantmonu51 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make as of clause sticky #9015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions ...n/src/features/dashboards/time-controls/super-pill/new-time-dropdown/RangePickerV2.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
import {
constructAsOfString,
constructNewString,
convertLegacyTime,
isUsingLegacyTime,
} from "../../new-time-controls";
import PrimaryRangeTooltip from "./PrimaryRangeTooltip.svelte";
import { Clock, Check } from "lucide-svelte";
Expand Down Expand Up @@ -79,9 +81,21 @@
let timeAxisPickerOpen = false;
let searchValue: string | undefined = timeString;

let hasAsOfClause = false;
let snapToEnd = true;
let ref: RillTimeLabel | string | undefined = undefined;

$: if (timeString) {
try {
parsedTime = parseRillTime(timeString);

if (parsedTime?.asOfLabel) {
hasAsOfClause = true;
snapToEnd = !!parsedTime.asOfLabel.offset;
ref = parsedTime.asOfLabel.label;
} else if (ref === undefined) {
ref = RillTimeLabel.Latest;
}
} catch {
parsedTime = undefined;
}
Expand All @@ -93,13 +107,6 @@

$: usingLegacyTime = parsedTime?.isOldFormat;

$: hasAsOfClause = !!parsedTime?.asOfLabel;

$: snapToEnd = usingLegacyTime ? true : !!parsedTime?.asOfLabel?.offset;
$: ref = usingLegacyTime
? RillTimeLabel.Latest
: parsedTime?.asOfLabel?.label;

$: truncationGrain = getTruncationGrain(parsedTime);

$: dateTimeAnchor = returnAnchor(ref, zone);
Expand All @@ -114,7 +121,10 @@

function handleRangeSelect(range: string, ignoreSnap?: boolean) {
try {
const parsed = parseRillTime(range);
const normalizedRange = isUsingLegacyTime(range)
? convertLegacyTime(range)
: range;
const parsed = parseRillTime(normalizedRange);

const isPeriodToDate =
parsed.interval instanceof RillPeriodToGrainInterval;
Expand Down
Loading