feat: add analyst agent support for canvas dashboard #8669
+2,515
−1,286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaHegde
changed the title
begelundmuller
requested changes
Jan 30, 2026
| **Phase 1: discovery (setup)** | ||
| {{ if .explore }} | ||
| Your goal is to analyze the contents of the dashboard "{{ .explore }}", which is powered by the metrics view "{{ .metrics_view }}". | ||
| Your goal is to analyze the contents of the dashboard "{{ .explore }}", which is powered by the metrics view "{{ .metrics_views }}". |
Contributor
There was a problem hiding this comment.
Plural + removing quotes since it's quoted by the code now
Suggested change
| Your goal is to analyze the contents of the dashboard "{{ .explore }}", which is powered by the metrics view "{{ .metrics_views }}". | |
| Your goal is to analyze the contents of the dashboard "{{ .explore }}", which is powered by the metrics view(s) {{ .metrics_views }}. |
| 1. Carefully study the metrics view definition to understand the measures and dimensions available for analysis. | ||
| 2. Remember the time range of available data and use it to inform and filter your queries. | ||
| {{ else if .canvas }} | ||
| Your goal is to analyze the contents of the canvas "{{ .canvas }}", which is powered by the metrics view "{{ .metrics_views }}". |
Contributor
There was a problem hiding this comment.
Suggested change
| Your goal is to analyze the contents of the canvas "{{ .canvas }}", which is powered by the metrics view "{{ .metrics_views }}". | |
| Your goal is to analyze the contents of the canvas "{{ .canvas }}", which is powered by the metrics view(s) {{ .metrics_views }}. |
Comment on lines
+8
to
+15
| runtimev1 "github.com/rilldata/rill/proto/gen/rill/runtime/v1" | ||
| "github.com/rilldata/rill/runtime/drivers" | ||
| "github.com/rilldata/rill/runtime/metricsview/metricssql" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
| ) | ||
|
|
||
| func (r *Runtime) ResolveCanvas(ctx context.Context, instanceID, canvas string, claims *SecurityClaims) (*runtimev1.ResolveCanvasResponse, error) { |
Contributor
There was a problem hiding this comment.
Since the runtime package is not server-specific, it should not use any of the server types, like codes or runtimev1.ResolveCanvasResponse.
I think the idiomatic way to handle the result here would be to add a ResolveCanvasResult type right in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for analyst agent for canvas dashboards.
Closes APP-674
Checklist: