Namanmahor/plat 265 support file size info reading #8663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport-file-size-info-reading
…upport-file-size-info-reading
…upport-file-size-info-reading
begelundmuller
requested changes
Jan 28, 2026
Comment on lines
+67
to
+71
| // Lists objects within a folder-like level (using path prefix and delimiter). | ||
| string path = 4; | ||
| string delimiter = 5; | ||
| uint32 page_size = 6 [(validate.rules).uint32 = {ignore_empty: true, lte: 100}]; | ||
| string page_token = 7; | ||
| // Lists objects matching the glob pattern. | ||
| string glob = 6; |
Contributor
There was a problem hiding this comment.
Suggested change
| // Lists objects within a folder-like level (using path prefix and delimiter). | |
| string path = 4; | |
| string delimiter = 5; | |
| uint32 page_size = 6 [(validate.rules).uint32 = {ignore_empty: true, lte: 100}]; | |
| string page_token = 7; | |
| // Lists objects matching the glob pattern. | |
| string glob = 6; | |
| // Lists objects within a folder-like level (using path prefix and delimiter). Cannot be used if `glob` is passed. | |
| string path = 4; | |
| string delimiter = 5; | |
| // Lists objects matching the glob pattern. Cannot be used if `path` or `delimiter` is passed. | |
| string glob = 6; |
Comment on lines
+76
to
+80
| entries, err := pagination.CollectAll(ctx, | ||
| func(ctx context.Context, pz uint32, tk string) ([]drivers.ObjectStoreEntry, string, error) { | ||
| return b.ListObjectsForGlob(ctx, opts.Glob, pz, tk) | ||
| }, | ||
| 1000) |
Contributor
There was a problem hiding this comment.
Does this add new network overhead?
I'm wondering if it would be better to still also support full listings in ListObjectsForGlob (e.g. pageSize == 0 could mean return all).
Comment on lines
+86
to
+102
| // Handle GCS | ||
| var q *storage.Query | ||
| if as(&q) { | ||
| // Only fetch the fields we need. | ||
| _ = q.SetAttrSelection([]string{"Name", "Size", "Created", "Updated"}) | ||
| if startAfter != "" { | ||
| q.StartOffset = startAfter | ||
| } | ||
| } | ||
| // Handle S3 | ||
| var s3Input *s3.ListObjectsV2Input | ||
| if as(&s3Input) { | ||
| if startAfter != "" { | ||
| s3Input.StartAfter = aws.String(startAfter) | ||
| } | ||
| } | ||
| return nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLAT-265: Support file size info reading
Checklist: