Adopts ex_quality 0.14.0 format check-mode - #16
Merged
Conversation
Bumps ex_quality to ~> 0.14 and sets `format: [check: true]` in .quality.exs (sui-b5y, fleet-wide decision 2026-08-22): the gate now fails on formatting drift instead of rewriting files, so unformatted code can no longer pass and agents run `mix format` themselves before committing. No file needed a pre-flip format pass - the tree was already clean. Red path verified locally: a deliberately unformatted scratch file turned the Format stage red with the file listed and its content untouched, then was removed. Updates the CLAUDE.md gate guidance that claimed the gate formats code for you. Refs: sp-987
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Format stage's write-mode default means formatting can never fail the
gate: unformatted code passes while the gate silently rewrites the working
tree mid-run. The fleet decision on sui-b5y (operator-confirmed 2026-08-22)
moves every repo's gate to check-mode instead.
What
ex_qualityto~> 0.14(0.14.0 in the lock).format: [check: true]in.quality.exs: drift fails the stagewith the file list and nothing is rewritten.
for you; agents now run
mix formatthemselves before committing.Notes
formatted, so the flip commit is pure config.
turned the Format stage red with the file listed and its content byte
identical afterward, then was removed.
mix qualitygreen on this tree (scope all, no profile; Formatreports
files_needing_format: 0);mix gate.verifyattests it.Doctor/Gettext/Sobelow are not installed in this project and are
declared not-applicable.
Closes: sp-987