Moves the format stage to check mode - #31
Merged
Merged
Conversation
Bumps ex_quality to ~> 0.14 and sets format: [check: true] in .quality.exs, per the operator's fleet-wide sui-b5y decision (2026-08-22): a gate that rewrites drifting files cannot report drift as a finding, so in CI unformatted code passed instead of going red. Drift now fails the stage and nothing is rewritten. Updates CLAUDE.md's build guidance to match: run mix format yourself before committing - the gate no longer formats for you. Refs: sui-b5y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The gate's format stage reformatted drifting files instead of checking
them. Locally that is convenient; in CI it means a push with unformatted
code can never go red on formatting - the runner tidies the drift and
passes, which defeats the point of a second observer that can say no. A
stage that fixes what it finds cannot report a finding (sui-b5y).
What
ex_qualityto~> 0.14- 0.14.0 adds the Format stage's checkknob, the upstream fix this bead was blocked on.
format: [check: true]in.quality.exs, with the reasonrecorded at the setting. Drift now fails the stage and nothing is
rewritten. The local convenience behaviour is removed deliberately,
not preserved: local and CI runs stay one definition, and an agent
that skips the formatter sees a red gate instead of a silent tidy.
mix formatbeforecommitting - the gate no longer formats for you.
No file was unformatted at the flip, so no separate formatting commit
was needed and this diff is pure config plus guidance.
Notes
mix quality/mix gate.verifygreen after rebase: scope all,no profile, 360/360 tests, 94.1% coverage.
2026-08-22, recorded on sui-b5y); sibling repos adopt via their own
beads.
changelog.d/README.md.Closes sui-b5y