Adds adoption caveats to family reference - #220
Merged
Conversation
Two adoption rules learned live during the 2026-08 fleet campaigns, so the next adopting repo reads them instead of rediscovering them. CI: the gate must run in the same env the gate tooling is defined for - a global MIX_ENV drops a dev-only gate task out of the build it protects - and stacked-request CI triggering must be verified on a live request rather than read off the workflow file. gate.verify: st-hcgl's resolution folds into the exception section and its table row. A git-dep consumer already inherits this repo's mix tasks, so a verbatim copy redefines a module and reddens the gate; the ruling is to wire gate.attest to the dep-provided task and take no copy. The verbatim path stays live only for a repo that is not on statifier as a git dep. Refs: st-6h8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docs/family-reference.mdtells the sibling repos what to copy from here.Two of its instructions were wrong or incomplete in ways only discovered by
running them during the 2026-08 fleet campaigns, so the next adopting repo
would have rediscovered both the hard way.
What
CI guidance. A new subsection under "What is not reference and never was"
states two rules the workflow file cannot tell you on its own. First, the gate
must run in the same env its tooling is defined for: predicator-ex's workflow
set a global
MIX_ENV=testwhile ex_quality isonly: :dev, so the gate taskdid not exist in CI at all and the gap surfaced only on the first live run.
Second, CI trigger behavior for requests based on non-default branches must be
verified on a live request - a campaign report asserted stacked requests get no
CI run, and the very next stacked request ran CI anyway.
The
gate.verifycaveat. The section markinggate.verifycopy-verbatimnow carries st-hcgl's resolution, and the table row is narrowed to match. A
git-dep consumer already inherits this repo's mix tasks through the compiled
lib/, so a verbatim local copy redefines a module andwarnings_as_errorsturns that into a red gate. The 2026-08-22 ruling was option (a): wire
gate.attestto the dep-provided task and take no copy. The verbatim pathremains live only for a repo that is not on statifier as a git dep. The Hex
package excludes
lib/mix, so the collision is git-dep-specific anddisappears at publication, and st-wgr0's extraction is kept framed as the
eventual fix that was deliberately deferred rather than the one adopted.
Notes
Docs-only diff, so
gate.rbreported its carve-out and no quality gate ran -that is a skipped gate, not a green one.
mix quality --profile mergerananyway per this repo's
/wurk:mrextension and was fully green; its ADR judgestage skipped cleanly because
docs/is not a judged ADR scope. No changelogfragment: this is an agent-facing internal document with no public surface.
Closes st-6h8d