Adopts ex_quality 0.14.0 format check-mode - #219
Merged
Conversation
Bumps the :ex_quality dev dependency from ~> 0.13 to ~> 0.14 and sets format: [check: true] in .quality.exs. The Format stage now runs mix format --check-formatted: drift fails the gate with the file list and the gate rewrites nothing, instead of silently formatting during a run. The tree was verified fully formatted before the flip, so this lands as pure config with no formatting commit ahead of it. A deliberately unformatted file was confirmed to turn the gate red, then reverted. The ADR-0011 ledger entry in docs/quality-gate-changes.md records the operator ruling behind the .quality.exs and mix.exs edits (deciding bead sui-b5y in statifier-ui, ruled fleet-wide 2026-08-22). CLAUDE.md's Build & Test guidance now says to run mix format before committing, since the gate no longer formats for you. Refs: st-k7pm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The fleet-wide format ruling (deciding bead sui-b5y in statifier-ui,
design PLAN-format-check-mode.md in ex_quality, operator-confirmed
2026-08-22) moves every repo's Format stage from rewrite mode to check
mode, so the quality gate reports unformatted files instead of silently
rewriting code during a gate run.
What
:ex_qualitydev dependency~> 0.13->~> 0.14(0.14.0 is the release that ships check mode).
format: [check: true]in.quality.exs- the only change tothat file.
docs/quality-gate-changes.mdrecording the operator ruling behind the
.quality.exsandmix.exsedits.
for you - run
mix formatbefore committing. The dep-synced ExQualityblock makes no auto-format claim and is untouched; no
.claude/wurk/*.mdfile echoed the old guidance.The tree was verified fully formatted before the flip, so this lands as
a single pure-config commit with no formatting commit ahead of it.
Notes
mix gate.verifyfull green ("Full gate green: scope all, noprofile, 13 stages considered"), with the Format stage reporting
files_needing_format: 0in check mode.mix quality --profile mergegreen; the ADR judge skipped cleanly(no files in the diff are in a judged ADR scope).
turns the gate red (
Format: 1 file needs formatting) and the gaterewrites nothing; reverted afterward. CI runs
mix gate.verify, sothe same check applies there.
Closes st-k7pm