Another set of refactoring changes#120
Open
LiamMehle wants to merge 8 commits intorichonguzman:mainfrom
Open
Conversation
if they're not used in other translation units, functions can be marked static to avoid them being needlessly exported by the compiler
marking variables as const is generally good practice
`String` is a heap-allocated string. One is created implicitly due to the return type of the helper functions. They're not mutated, so a reference to a static String that is allocated once can be returned instead.
returning from a function returns control flow back to the calling function immediately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set of commits includes: