Update README installation steps#1
Merged
richardmarbach merged 1 commit intorichardmarbach:mainfrom Apr 17, 2024
Merged
Conversation
Owner
|
Hey, thanks for taking the time to improve the instructions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for creating this plugin! I understand that it is still waiting for Shopify/packwerk#375 to be merged.
I tested this plugin with Shopify/packwerk#375, and there were a couple of updates to get everything to work. I wanted to submit them upstream.
packwerk.ymldid not work with a hyphen but did with an underscorehamlfiles to the Packwerk config as they're ignored in the default configuration