Add missing case to test COALESCE order logic#26
Open
replakcan wants to merge 1 commit intorhc2104:masterfrom
Open
Add missing case to test COALESCE order logic#26replakcan wants to merge 1 commit intorhc2104:masterfrom
replakcan wants to merge 1 commit intorhc2104:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new row to the
fightersdataset where bothgunandswordare provided whiletankis null. This allows the "Coalesce" task to better test the order of precedence when selecting the strongest available weapon.To maintain the existing order based on weapon strength (tank > gun > sword > null), the new row was inserted as
id: 2, and the IDs of subsequent entries were incremented accordingly.New entry:
{
id: 2,
name: "Spec Ops Operative",
gun: "Glock 17",
sword: "Fairbairn Sykes Dagger",
tank: null
}
Without this case,
COALESCE(tank, gun, sword)andCOALESCE(tank, sword, gun)both produce the same results. This addition ensures correct ordering is actually evaluated.Suggested in reference to Issue #[25].