Skip to content

Change animals_by to accept any key equivalent to to an animal attribute #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aelmahmoudy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change animals_by to accept any key equivalent to to an animal attribute #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ch09-objects/e45b3_color_and_legs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,4 @@ def animals_by(self, **kwargs):
return [one_animal
for one_cage in self.cages
for one_animal in one_cage.animals
if (('color' in kwargs and one_animal.color == kwargs['color']) and
('legs' in kwargs and one_animal.number_of_legs == kwargs['legs']))]
if all(key in vars(one_animal) and getattr(one_animal,key) == kwargs[key] for key in kwargs)]