Skip to content

No need to convert string.* to sets #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aelmahmoudy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

No need to convert string.* to sets #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ch06-functions/e27b1_password_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,27 @@


def create_password_checker(min_uppercase, min_lowercase, min_punctuation, min_digits):
uppercase_set = set(string.ascii_uppercase)
lowercase_set = set(string.ascii_lowercase)
punctuation_set = set(string.punctuation)
digits_set = set(string.digits)

def check_password(password):

if len([one_character
for one_character in password
if one_character in uppercase_set]) < min_uppercase:
if one_character in string.ascii_uppercase]) < min_uppercase:
print(f'Not enough uppercase letters; min is {min_uppercase}')
return False
elif len([one_character
for one_character in password
if one_character in lowercase_set]) < min_lowercase:
if one_character in string.ascii_lowercase]) < min_lowercase:
print(f'Not enough lowercase letters; min is {min_lowercase}')
return False
elif len([one_character
for one_character in password
if one_character in punctuation_set]) < min_punctuation:
if one_character in string.punctuation]) < min_punctuation:
print(f'Not enough punctuation; min is {min_punctuation}')
return False
elif len([one_character
for one_character in password
if one_character in digits_set]) < min_digits:
if one_character in string.digits]) < min_digits:
print(f'Not enough digits; min is {min_digits}')
return False
else:
Expand Down