fix(ui): keep sidebar scroll when switching emails#3677
Open
ivenuss wants to merge 1 commit into
Open
Conversation
Contributor
|
@ivenuss is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: Cursor <cursoragent@cursor.com>
ivenuss
force-pushed
the
ivenus/fix-sidebar-scroll-position
branch
from
July 22, 2026 22:03
2a0d5ef to
9538435
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Navigating between emails remounted Shell on every page, so the sidebar lost its scroll position.
Fix
Move
Shellinto the root layout so it stays mounted across routes, and derive the active email from useParams() instead of passing currentEmailOpenSlug down the tree.Demonstration of the issue
ui.mov
Summary by cubic
Preserves the sidebar scroll position when switching between emails by keeping the shell mounted and deriving the active email from the route.
Shelltoapp/layout.tsxso the sidebar stays mounted across routes.Shellwrappers inapp/page.tsxandapp/preview/[...slug]/page.tsx.useParams()(decodes joinedslug); removed thecurrentEmailOpenSlugprop.shell.tsxandsidebar.tsx.Written for commit 9538435. Summary will update on new commits.