Skip to content

fix(editor): reset margin/padding on the minimal mode#3676

Draft
danilowoz wants to merge 1 commit into
canaryfrom
07-22-fix_editor_reset_margin_padding_on_the_minimal_mode
Draft

fix(editor): reset margin/padding on the minimal mode#3676
danilowoz wants to merge 1 commit into
canaryfrom
07-22-fix_editor_reset_margin_padding_on_the_minimal_mode

Conversation

@danilowoz

@danilowoz danilowoz commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Reset body margin and padding to 0 in the editor’s minimal theme to remove unwanted spacing and ensure consistent email rendering. Moved defaults into the theming config and added support for margin as a CSS property.

  • Bug Fixes

    • Minimal mode: body margin and padding now default to 0 via theme (RESET_BASIC, THEME_MINIMAL) to eliminate browser spacing.
    • Removed inline margin/padding from Body in @editor and rely on mergedStyles.body.
  • New Features

    • Added margin to SUPPORTED_CSS_PROPERTIES and types (px, default 0) for theme-level control.

Written for commit 467fbe5. Summary will update on new commits.

Review in cubic

@changeset-bot

changeset-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 467fbe5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Jul 22, 2026 5:06pm
react-email-demo Ready Ready Preview, Comment Jul 22, 2026 5:06pm

@pkg-pr-new

pkg-pr-new Bot commented Jul 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/editor@3676

commit: 467fbe5

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Moves body margin/padding reset into the theme configuration and adds margin as a supported CSS property, enabling user customization. No behavioral change in minimal mode.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant