refactor(editor): replace lucide-react with inline SVG icons#3106
Open
joaopcm wants to merge 2 commits intojoaopcm/editor-examples-appfrom
Open
refactor(editor): replace lucide-react with inline SVG icons#3106joaopcm wants to merge 2 commits intojoaopcm/editor-examples-appfrom
joaopcm wants to merge 2 commits intojoaopcm/editor-examples-appfrom
Conversation
Remove lucide-react peer dependency by inlining static SVG components extracted from Lucide's icon set. Icons exported from @react-email/editor/ui for consumer use.
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
One TSX component per icon file under src/ui/icons/. No shared abstractions — each file is a self-contained SVG component.
commit: |
gabrielmfern
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lucide-reactpeer dependency with 29 inline SVG icon components inpackages/editor/src/ui/icons.tsxlucide-reactfrom editor'speerDependencies, making the package self-contained@react-email/editor/uiso consumers can reuse themTest plan
pnpm --filter @react-email/editor buildpassespnpm --filter @react-email/editor testpasses (318/318)pnpm lint:fixpasseslucide-reactimports remain inpackages/editor/src/Summary by cubic
Replaced
lucide-reactwith 29 inline SVG icon components, split into individual files under@react-email/editor/ui/iconsand re-exported from@react-email/editor/ui. This removes thelucide-reactpeer dependency and makes@react-email/editorself-contained.Refactors
packages/editor/src/ui/icons/with a barrelindex.ts.../iconsacross bubble menus, link forms, image link forms, and slash commands.@react-email/editor/uifor consumer reuse.Migration
lucide-reactwhen using@react-email/editor.lucide-react, switch to@react-email/editor/ui(e.g.,import { BoldIcon } from '@react-email/editor/ui').Written for commit fbb9226. Summary will update on new commits.