Skip to content

refactor: complete Canvas interface ownership - #337

Merged
jderochervlk merged 1 commit into
codex/option5-navigator-folderfrom
codex/option5-canvas-values
Aug 7, 2026
Merged

refactor: complete Canvas interface ownership#337
jderochervlk merged 1 commit into
codex/option5-navigator-folderfrom
codex/option5-canvas-values

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 27 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #336.

Summary

  • move ImageData and VideoColorSpace from the legacy DOM folder into src/canvas
  • expose both existing flat interface modules through WebAPI.Canvas
  • leave the Canvas feature dependency closure unchanged

Why this follows the Canvas PR

The initial Canvas layer focused on the existing Canvas source folder. These two value interfaces were still published from the broad DOM folder even though their types and consumers belong to Canvas. Keeping this as a two-file follow-up makes that ownership correction explicit.

Temporary state

  • ScreenOrientation remains the last clear non-Window interface in the legacy DOM folder and moves in the next Device follow-up
  • the remaining legacy DOM source entry is removed by the subsequent Window layer
  • final feature-graph guardrails and helper cleanup remain deferred until the stack is complete

Review focus

  • ownership of the two value interfaces
  • unchanged flat public module paths and Canvas closure

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media,SVG,Canvas
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: ab8b5e46df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from ab8b5e4 to 114f3d4 Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch 2 times, most recently from 43a42af to 8d858a4 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 8d858a4 to 07fa88c Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch 2 times, most recently from b299c25 to fd69a8e Compare August 5, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch 2 times, most recently from 44454e9 to ffd07d5 Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from ffd07d5 to 070d3e0 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch 2 times, most recently from 6783b9e to 62ca590 Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 62ca590 to 4f9756b Compare August 5, 2026 17:40
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 4f9756b to 4193469 Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 9c8b8ce to 2a416e9 Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 2a416e9 to 2207593 Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch 2 times, most recently from 8e18e93 to 9d2f72f Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 9d2f72f to c18ff4d Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from c18ff4d to 704023f Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 704023f to 8471792 Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 8471792 to 6ea3bab Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 6ea3bab to 3159c3c Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 3159c3c to 4a0c8cd Compare August 7, 2026 14:01
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 4a0c8cd to 8015f15 Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 8015f15 to 28c5386 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 28c5386 to 1a6dc9b Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-canvas-values branch from 1a6dc9b to b3db63c Compare August 7, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants