Skip to content

refactor: establish WebAudio folder feature - #329

Merged
jderochervlk merged 1 commit into
codex/option5-media-folderfrom
codex/option5-web-audio-folder
Aug 7, 2026
Merged

refactor: establish WebAudio folder feature#329
jderochervlk merged 1 commit into
codex/option5-media-folderfrom
codex/option5-web-audio-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 19 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #328.

Summary

  • rename src/WebAudio to the target src/web-audio folder
  • switch the folder to the unqualified internal WebAudio feature
  • add the supported WebAPI.WebAudio -> WebAPI.Media + WebAPI.Messaging + WebAudio feature
  • preserve all existing flat WebAudio module paths and binding signatures

Dependency note

The Option 5 proposal listed only Media as a public dependency. The current bindings also expose MessagePort from AudioWorkletNode.port, so the compiler-proven closure additionally requires WebAPI.Messaging. This PR records the real public signature dependency at the domain level.

Temporary state

  • the legacy broad WebAPI.DOM source entry remains until its remaining interfaces have been assigned
  • final feature-graph guardrails and cleanup remain deferred until the stack is complete

Review focus

  • the lowercase folder/internal feature transition
  • the additional Messaging dependency
  • preservation of flat public module names

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media,Messaging,WebAudio
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d44e1a7b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 0d44e1a to 2bdc163 Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch 2 times, most recently from 1de339d to 827f126 Compare August 5, 2026 12:31
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch 2 times, most recently from 0e61014 to 6631cc1 Compare August 5, 2026 13:40
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch 3 times, most recently from d291f81 to 806cf99 Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 806cf99 to 490d3c1 Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch 2 times, most recently from 066c385 to b96e7b3 Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from b96e7b3 to 3c685fb Compare August 5, 2026 17:40
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 3c685fb to 1e552e9 Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch 2 times, most recently from e71ee80 to ce46bfb Compare August 6, 2026 15:04
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from dc5e836 to 4ea5552 Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 4ea5552 to 68dd5b1 Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 68dd5b1 to ebe9d0f Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from ebe9d0f to a7505bb Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from a7505bb to c04424c Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from c04424c to 078d6fb Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 078d6fb to 385c3da Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 385c3da to 1655de2 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 1655de2 to 3206b00 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 3206b00 to 5367835 Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 5367835 to 0478e76 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 0478e76 to fa0a742 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from fa0a742 to 8323fd7 Compare August 7, 2026 14:07
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 8323fd7 to 1c7cd11 Compare August 7, 2026 14:09
@jderochervlk
jderochervlk force-pushed the codex/option5-web-audio-folder branch from 1c7cd11 to 3e96e48 Compare August 7, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants