Skip to content

refactor: establish CSSOM folder feature - #325

Merged
jderochervlk merged 1 commit into
codex/option5-geometry-folderfrom
codex/option5-cssom-folder
Aug 7, 2026
Merged

refactor: establish CSSOM folder feature#325
jderochervlk merged 1 commit into
codex/option5-geometry-folderfrom
codex/option5-cssom-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 15 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #324.

Summary

  • add the target src/cssom folder on the unqualified internal CSSOM feature
  • move stylesheet, CSS declaration/value, media-query, and style-property-map interfaces out of the legacy DOM folder
  • add the supported WebAPI.CSSOM feature
  • preserve all nine flat public interface module paths and binding signatures

Dependency direction

The proposal had CSSOM imply DOMNodes. The compiler graph shows the opposite direction:

  • CSSOM itself needs only the Event foundation, through MediaQueryList
  • DOMTree and Element reference CSSOM-owned types
  • making CSSOM imply DOMNodes would therefore create a cycle

This layer defines WebAPI.CSSOM -> WebAPI.Event + CSSOM. The DOMNodes layer will imply CSSOM.

Temporary state

  • several CSSOM modules still expose shared records rooted in earlier compatibility types; final type ownership cleanup remains deferred
  • this PR introduces no file exclusions or module slices

Review focus

  • the compiler-derived acyclic dependency direction
  • complete CSSOM folder membership
  • unchanged flat public modules

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,CSSOM
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: cc0bb1f0d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from cc0bb1f to c7324a1 Compare August 4, 2026 17:31
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from c7324a1 to 3e406a4 Compare August 5, 2026 12:14
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch 2 times, most recently from 205be64 to ff9923d Compare August 5, 2026 12:34
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch 4 times, most recently from 6b739ce to 7cd73de Compare August 5, 2026 14:30
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 7cd73de to 460967e Compare August 5, 2026 14:50
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch 2 times, most recently from 4b52d6d to f6ae493 Compare August 5, 2026 15:45
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from f6ae493 to 9041a13 Compare August 5, 2026 17:40
@jderochervlk
jderochervlk requested review from brnrdog and tsnobip August 6, 2026 14:45
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 9041a13 to 1a72f7d Compare August 6, 2026 14:52
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 1a72f7d to ac07460 Compare August 6, 2026 14:58
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from a6e372a to ac43299 Compare August 7, 2026 13:45
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from ac43299 to f2e41a5 Compare August 7, 2026 13:50
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from f2e41a5 to 8131591 Compare August 7, 2026 13:54
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 8131591 to cb1e06f Compare August 7, 2026 13:56
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from cb1e06f to 03ddfe8 Compare August 7, 2026 13:57
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 03ddfe8 to fd314e8 Compare August 7, 2026 13:58
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from fd314e8 to 0d97c10 Compare August 7, 2026 13:59
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 0d97c10 to 40c7e81 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 40c7e81 to 4556a55 Compare August 7, 2026 14:00
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 4556a55 to 108af43 Compare August 7, 2026 14:03
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 108af43 to 8f27698 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 8f27698 to d845569 Compare August 7, 2026 14:04
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from d845569 to 8974e66 Compare August 7, 2026 14:07
@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from 8974e66 to bd57293 Compare August 7, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants