Skip to content

Fix imageData.data type #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nojaf merged 4 commits into from
Jan 9, 2026
Merged

Fix imageData.data type #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4f6577
Fix imageData.data type
alex35mil Jan 9, 2026
6fe2fbc
Rename ImageData.make2 to ImageData.makeWithData
alex35mil Jan 9, 2026
8d151be
Add ImageData tests
alex35mil Jan 9, 2026
6226e6a
rename ImageData test
alex35mil Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DOMAPI.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3020,7 +3020,7 @@ and htmlCollectionOf<'t> = {
}

/**
A collection of HTML form control elements.
A collection of HTML form control elements.
[See HTMLFormControlsCollection on MDN](https://developer.mozilla.org/docs/Web/API/HTMLFormControlsCollection)
*/
@editor.completeFrom(HTMLFormControlsCollection) and htmlFormControlsCollection = {
Expand Down Expand Up @@ -9403,7 +9403,7 @@ type imageData = {
Returns the one-dimensional array containing the data in RGBA order, as integers in the range 0 to 255.
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/ImageData/data)
*/
data: array<int>,
data: Uint8ClampedArray.t,
/**
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/ImageData/colorSpace)
*/
Expand Down
4 changes: 2 additions & 2 deletions src/DOMAPI/ImageData.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ external make: (~sw: int, ~sh: int, ~settings: imageDataSettings=?) => imageData
[Read more on MDN](https://developer.mozilla.org/docs/Web/API/ImageData)
*/
@new
external make2: (
~data: array<int>,
external makeWithData: (
~data: Uint8ClampedArray.t,
~sw: int,
~sh: int=?,
~settings: imageDataSettings=?,
Expand Down
11 changes: 11 additions & 0 deletions tests/DOMAPI/ImageData__test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions tests/DOMAPI/ImageData__test.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
open DOMAPI
Copy link
Member

@nojaf nojaf Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename file to ImageData_test.res please

Copy link
Contributor Author

@alex35mil alex35mil Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, done

Copy link
Member

@nojaf nojaf Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!


let imageData = ImageData.makeWithData(~data=Uint8ClampedArray.fromArray([]), ~sw=100, ~sh=100)

imageData.data->TypedArray.length->Console.log