-
Notifications
You must be signed in to change notification settings - Fork 58
fix: macOS icon sizes and organize assets folder #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
buraian
wants to merge
2
commits into
requestly:master
Choose a base branch
from
buraian:chore/fix-macos-icon-sizes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−29
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Assets Directory | ||
|
|
||
| ## File Structure | ||
|
|
||
| ``` | ||
| assets/ | ||
| ├── AppIcon.png # Mac master source (1024x1024) - for icns generation & SetApp | ||
| ├── prep-icons.sh # Generate icon.icns from AppIcon.png | ||
| ├── README.md # This file | ||
| │ | ||
| ├── icon.icns # Mac app icon (generated by prep-icons.sh) | ||
| ├── icon.ico # Windows app icon | ||
| ├── icon.png # Linux/Windows BrowserWindow icon (256x256) | ||
| ├── iconTemplate.png # macOS tray icon | ||
| ├── iconTemplate@2x.png # macOS tray icon (Retina) | ||
| ├── iconTemplate@2x.ico # Windows tray icon (high DPI) | ||
| │ | ||
| ├── icons/ # Linux icons ONLY (electron-builder auto-uses) | ||
| │ ├── 16x16.png | ||
| │ ├── 32x32.png | ||
| │ ├── 64x64.png | ||
| │ ├── 128x128.png | ||
| │ ├── 256x256.png | ||
| │ ├── 512x512.png | ||
| │ └── 1024x1024.png | ||
| │ | ||
| ├── entitlements.mac.plist # macOS entitlements for code signing | ||
| ├── requirement.rqset # macOS code signing requirements | ||
| └── assets.d.ts # TypeScript declarations for asset imports | ||
| ``` | ||
|
|
||
| ## Regenerating macOS Icons | ||
|
|
||
| After updating `AppIcon.png`, run `prep-icons.sh`. | ||
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| #!/usr/bin/env sh | ||
|
|
||
| # Generate icon.icns from AppIcon.png for macOS | ||
| # This script creates a temporary iconset folder, generates all required sizes, | ||
| # converts to icns, then cleans up. | ||
|
|
||
| set -e | ||
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" | ||
| SOURCE="$SCRIPT_DIR/AppIcon.png" | ||
| OUTPUT="$SCRIPT_DIR/icon.icns" | ||
| ICONSET="$SCRIPT_DIR/icon.iconset" | ||
|
|
||
| if [ ! -f "$SOURCE" ]; then | ||
| echo "Error: Source file not found: $SOURCE" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Generating icon.icns from AppIcon.png..." | ||
|
|
||
| # Remove existing iconset if present | ||
| rm -rf "$ICONSET" | ||
| mkdir "$ICONSET" | ||
|
|
||
| # Generate all required icon sizes for macOS | ||
| # Format: filename - size | ||
| # @2x variants are double the base size | ||
|
|
||
| sips -z 16 16 "$SOURCE" --out "$ICONSET/icon_16x16.png" | ||
| sips -z 32 32 "$SOURCE" --out "$ICONSET/icon_16x16@2x.png" | ||
| sips -z 32 32 "$SOURCE" --out "$ICONSET/icon_32x32.png" | ||
| sips -z 64 64 "$SOURCE" --out "$ICONSET/icon_32x32@2x.png" | ||
| sips -z 128 128 "$SOURCE" --out "$ICONSET/icon_128x128.png" | ||
| sips -z 256 256 "$SOURCE" --out "$ICONSET/icon_128x128@2x.png" | ||
| sips -z 256 256 "$SOURCE" --out "$ICONSET/icon_256x256.png" | ||
| sips -z 512 512 "$SOURCE" --out "$ICONSET/icon_256x256@2x.png" | ||
| sips -z 512 512 "$SOURCE" --out "$ICONSET/icon_512x512.png" | ||
| sips -z 1024 1024 "$SOURCE" --out "$ICONSET/icon_512x512@2x.png" | ||
|
|
||
| # Convert to icns (macOS only) | ||
| iconutil -c icns "$ICONSET" -o "$OUTPUT" | ||
|
|
||
| # Clean up | ||
| rm -rf "$ICONSET" | ||
|
|
||
| echo "Successfully generated: $OUTPUT" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.