feat(build): add the ovsx CLI for Open VSX publishing - #109
Merged
Conversation
reqstool/.github#99 replaces HaaLeo/publish-vscode-extension with the registries' own CLIs, invoked as `npx --no-install`. vsce is already here -- scripts/build.mjs shells out to it -- but ovsx was supplied by the action and has to become a real dependency. Pinned exactly, like vsce, so Renovate manages both from this lockfile rather than a version floating in the shared workflow. npm audit is unchanged: same 4 pre-existing findings, all via mocha, none from ovsx. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to reqstool/.github#99; part of reqstool/.github#98.
Description
That PR replaces
HaaLeo/publish-vscode-extensionwith the registries' own CLIs, invoked asnpx --no-install.@vscode/vsceis already a devDependency here —scripts/build.mjsshells out tovsce packageto build the VSIX — butovsxwas previously supplied by the action, so it has to become a real dependency.Pinned exactly at
1.1.1to match how@vscode/vsce@3.9.2is pinned, so Renovate manages both from this lockfile rather than a version floating in the shared workflow.Merge this before reqstool/.github#99 —
--no-installmeans the first publish after that merges would fail outright ifovsxisn't here. That's deliberate: a clear failure beats silently pulling an unpinned CLI from the network into a job holding publish credentials.Why the CLIs at all
Azure DevOps retires global PATs on 2026-12-01. The action declares
patas required with no Entra ID support, so it can't follow us onto the replacement. It also still declaresnode20and hasn't had a commit since June 2025. Full detail in reqstool/.github#98.Checklist
git commit -s).Test plan
Verified locally that both CLIs resolve under the exact invocation the workflow uses:
npm auditis byte-identical before and after — same 4 pre-existing findings, all reached through mocha'sserialize-javascript, none introduced byovsx.