fix(ci): add explicit permissions to lint.yml - #103
Merged
Conversation
CodeQL flagged lint.yml (actions/missing-workflow-permissions): no permissions block anywhere in the file, so it runs with whatever the repo's default token permissions are rather than what it actually needs. It only checks out and reads the repo -- contents: read covers everything the job does. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the open CodeQL alert (
actions/missing-workflow-permissions) on this file: nopermissions:block anywhere, so it ran with the repo's default token permissions rather than what it actually needs. It only checks out and reads the repo —contents: readcovers it.Checklist
git commit -s).Test plan
YAML validated locally. CodeQL re-scan on this PR should close the alert.