fix(ci): fix build-docs.yml's dead workflow reference, add permissions - #188
Merged
Conversation
Two issues in the same file: - It called reqstool/.github/.github/workflows/build-docs.yml, which doesn't exist -- the actual file is common-build-docs.yml, as every other repo in the org already references. This workflow has been failing on every docs-path push or PR since 2026-06-23, unrelated to any recent migration. - CodeQL flagged the missing permissions block (actions/missing-workflow-permissions). common-build-docs.yml itself only requires contents: read, so that's what the caller now grants. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues in the same file:
reqstool/.github/.github/workflows/build-docs.yml, which doesn't exist — the actual file iscommon-build-docs.yml, as every other repo in the org already references. This workflow has been failing on every docs-path push or PR since 2026-06-23 (confirmed via run history), unrelated to any recent migration.permissions:block (actions/missing-workflow-permissions).common-build-docs.ymlitself only requirescontents: read, so that's what the caller now grants.Checklist
git commit -s).Test plan
YAML validated locally. A push touching
docs/**on this branch is the real test — it should now actually runcommon-build-docs.ymlinstead of failing immediately on a missing workflow file. CodeQL re-scan on this PR should close the alert.