Open
Conversation
- Use 1-node k3s clusters instead of 3-node; GKE keeps 3 nodes - Remove invalid skip-preflights and debug inputs from kots-install action - Replace 5-minute service poll loop with kubectl wait --for=condition=Available
There was a problem hiding this comment.
Pull request overview
This PR optimizes the MLflow CI workflow runtime by reducing k3s cluster size and simplifying the post-KOTS-install readiness logic to avoid unnecessary polling.
Changes:
- Update the cluster matrix to use 1-node k3s clusters (while keeping GKE at 3 nodes) and pass node count via
matrix.cluster.nodes. - Remove unsupported
skip-preflightsanddebuginputs fromreplicatedhq/replicated-actions/kots-install@v1.17.0. - Replace the service polling loop with
kubectl wait --for=condition=Availableand a shorter health-check loop before port-forward-based tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Poll for deployment existence before kubectl wait (avoids immediate failure if KOTS hasn't created the Deployment yet) - Add || true to kubectl diagnostics in error handler (prevents bash -e from swallowing the original error when describe returns non-zero) - Fail port-forward step explicitly if MLflow never becomes reachable, with pod logs and port-forward log printed before exiting non-zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip-preflightsanddebuginputs fromkots-install@v1.17.0— these are not valid inputs for this action version and were being silently ignored (preflights were running anyway, adding time)kubectl wait --for=condition=Available— by the time KOTS install completes, the deployment exists; no need to poll for the Service objectTest plan