fix: fix Go formatting and flaky torch_baseimage_fallback integration test#2817
Merged
michaeldwan merged 2 commits intomainfrom Mar 9, 2026
Merged
fix: fix Go formatting and flaky torch_baseimage_fallback integration test#2817michaeldwan merged 2 commits intomainfrom
michaeldwan merged 2 commits intomainfrom
Conversation
…f cog build The test was doing a real Docker build with torch==1.13.0 which failed because pip can no longer reliably install this old package. Since the test's purpose is to verify Dockerfile generation falls back to nvidia/cuda (not cog-base), use cog debug to check the generated Dockerfile text. Uses an empty local registry for deterministic behavior.
michaeldwan
changed the title
markphelps
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integration-tests/harness/harness.gothat was failing the "Format Go" CI job.torch_baseimage_fallbackintegration test from a realcog build(which failed becausepip install torch==1.13.0is no longer reliable) tocog debug, which just verifies the generated Dockerfile text falls back tonvidia/cudainstead ofcog-base. Uses an empty local registry for deterministic behavior across environments.