Modernize: Ruby 4.0.1, clean up dev dependencies, and fix test suite#37
Closed
andyw8 wants to merge 8 commits intorenuo:mainfrom
Closed
Modernize: Ruby 4.0.1, clean up dev dependencies, and fix test suite#37andyw8 wants to merge 8 commits intorenuo:mainfrom
andyw8 wants to merge 8 commits intorenuo:mainfrom
Conversation
- Update Ruby to 4.0.1 (add mise.toml) - Remove pinned version constraints from all dev dependencies - Remove byebug - Remove deprecated rails/tasks/statistics.rake from Rakefile Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace require "rake/testtask" with rspec/core/rake_task in Rakefile - Run db:migrate before specs in rake task - Add rspec-rails, webmock, ammeter to gemspec (were missing) - Add transactional fixtures and before hook to clean log tables - Fix specs using spec_helper instead of rails_helper for DB specs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andyw8
changed the title
Aligns CI with local development - rake now handles migrations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rails 6.1, 7.0, and 7.1 are all past end-of-life. Update minimum supported Rails to 7.2 and Ruby to 3.2, and remove EOL CI jobs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
coorasse
reviewed
Apr 7, 2026
Member
coorasse
left a comment
coorasse
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I left some initial comments.
| - bin/rails db:create db:migrate | ||
| - bundle exec rspec | ||
| - bin/rails db:prepare | ||
| - bundle exec rake |
Member
There was a problem hiding this comment.
I prefer to keep rspec explicitly here
| - sem-service start postgres 14 | ||
| - bin/rails db:create db:migrate | ||
| - bundle exec rspec | ||
| - bin/rails db:prepare |
| - sem-service start postgres 14 | ||
| - bin/rails db:create db:migrate | ||
| - bundle exec rspec | ||
| - name: tests postgres separate db and separate target | rails 6.1 |
Member
There was a problem hiding this comment.
why is support for rails 6 dropped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was co-authored with Claude Code. I have carefully verified it.
Summary