fix: repair the dead websiteUrl and guard the registry entry - #83
Merged
Conversation
The registry entry is published by a step that is continue-on-error, so anything wrong with it degrades to a warning in a log nobody reads. That is how the docs restructure in rendobar/docs#59 went unnoticed here: websiteUrl still pointed at /docs/mcp/, which now answers 405, and that URL is live in published registry version 1.7.1. The page moved to /docs/mcp-server. package.json homepage carried the same stale value. Adds scripts/check-registry-entry.mjs, run as its own CI job on every PR. It cross-checks the fields that break a publish after npm has already gone out - server.json name against package.json mcpName, the three release-please version fields against each other, the package identifier - enforces the registry's 100-char description cap, asserts a remotes entry exists, and fetches every URL in the entry. The icon URLs are the fragile ones: they resolve to the brand CDN, which is synced from a different repo, so nothing in this repo would otherwise notice them going dead. Also adds a post-publish verification step to release.yml that polls the registry until the released version is present and marked latest, and fails the job if it never is. That failure routes into the existing rollback-on-failure job, which opens an issue. npm has already published by then, so the fix is always forward. The script takes no dependencies. Node has fetch, and the failures that actually occur here are cross-file drift and dead URLs rather than exotic schema violations, which the post-publish check catches anyway.
| const signal = () => AbortSignal.timeout(15_000); | ||
| // Some hosts reject HEAD (Mintlify answers 405); fall back to a ranged | ||
| // GET rather than pulling the whole asset. | ||
| let res = await fetch(url, { method: "HEAD", redirect: "follow", signal: signal() }); |
| // GET rather than pulling the whole asset. | ||
| let res = await fetch(url, { method: "HEAD", redirect: "follow", signal: signal() }); | ||
| if (!res.ok) { | ||
| res = await fetch(url, { |
This was referenced Jul 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry publish step is
continue-on-errorby design, since npm is the source of truth. The side effect is that anything wrong withserver.jsondegrades to a warning in a log nobody reads.What that already cost us
websiteUrlpointed athttps://rendobar.com/docs/mcp/. That page moved to/docs/mcp-serverwhen rendobar/docs#59 consolidated the MCP docs, and the old path now answers 405:That dead URL is live in published registry version 1.7.1 right now, and it is what aggregators show.
package.jsonhomepagehad the same stale value. Both fixed here.Nothing in CI would have caught it, and nothing would have caught the next one either.
The guard
scripts/check-registry-entry.mjs, its own CI job on every PR. It checks the things that break a publish after npm has already gone out:server.jsonnamevspackage.jsonmcpName— a mismatch is a hard publish rejectionextra-files, against each otherpackages[0].identifiervs the npm package nameremotesentry exists, so the hosted server cannot silently vanish from the listing againThe URL check matters most for icons: they point at the brand CDN, synced from the monorepo, so this repo would never notice them going dead.
No dependencies. Node has
fetch, and the failures that actually happen here are cross-file drift and dead URLs, not exotic schema violations — those get caught below.Post-publish verification
release.ymlnow polls the registry after publishing until the released version is present and markedisLatest, failing the job if it never is. That routes into the existingrollback-on-failurejob, which opens an issue. npm has already published at that point, so the fix is always forward — re-run once the cause is addressed.Test plan
Guard, negative-tested by mutating a scratch copy. Baseline passes; every branch fails:
name!=mcpNameremotesremovedVerification step, extracted from the workflow and run against the live registry:
1.7.1(live, latest)1.7.0(present, superseded)9.9.9(absent)Also: all three workflow files parse as YAML,
tsc --noEmitclean,eslintclean, 72/72 tests pass.Two bugs found and fixed while testing the guard itself — a missing
fetchtimeout that hung the run past 120s, andprocess.exit()firing with a pendingAbortSignaltimer, which trips a libuv assertion on Windows and returns 127 instead of 1.