docs: trim the ffprobe page - #50
Merged
Merged
Conversation
Fanning out with Promise.all is standard client code, not something the job type needs to teach.
The section said the same thing three times: a diagram, a table, and a warning callout all describing which flags suppress which defaults. Kept the table, which is the precise mapping, and folded the rest into two sentences. The opening example dropped back to a bare URL in the rewrite. Show -show_format -show_streams instead, so the first thing a reader sees is a real command rather than the shorthand.
a-essawy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three cuts, no new claims.
Dropped the probe-many-files section. Fanning out with
Promise.allis standard client code, not something the job type needs to teach. It spent 20 lines on it.Simplified "What comes back." A diagram, a table, and a warning callout all described the same rule about which flags suppress which defaults. Kept the table, which is the precise mapping, and folded the diagram and the callout into two sentences.
The first example shows a real command again. The rewrite had reduced it to a bare URL. It now opens with
ffprobe -show_format -show_streams <url>across all three languages, so the reader's first sight is the full form rather than the shorthand. The bare-URL shorthand is still explained a paragraph later.Note: the concurrency-exemption fact (probes don't count against the plan limit,
CONCURRENCY_EXEMPT_JOB_TYPESinapps/api/src/lib/drain.ts) lived only in the removed section and is now unstated on the page. It is true and verified, so say the word if it should come back as a one-liner.Prose is 958 words. Frontmatter and plan-limit validators pass.