Skip to content

docs(onboarding)- add test to make sure submission keeps working - #1206

Open
gabrielseco wants to merge 10 commits into
mainfrom
test-france-contract_details-submission
Open

docs(onboarding)- add test to make sure submission keeps working#1206
gabrielseco wants to merge 10 commits into
mainfrom
test-france-contract_details-submission

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Add test to make sure submission works when contract_details are submitted

It recovers data from the server and submits to avoid submitting whole form


Note

Low Risk
Changes are limited to test fixtures and MSW setup; no production onboarding logic is modified.

Overview
Test-only changes that consolidate onboarding MSW mocks and add coverage for France contract-details submission when employment data is loaded from the server.

Shared MSW handlers for POST/PATCH employments, PUT benefit-offers, and currency conversion move from per-suite beforeEach overrides into defaultHandlers in handlers.ts, so suites like OnboardingFlow.test.tsx and OnboardingFlowFrance.test.tsx no longer duplicate them.

For France, the multi-step test harness now includes the Benefits step, and a new fixture employmentDefaultResponseFrance supplies server-backed contract details (including pre-filled annual gross salary). A new test walks basic information → contract details → benefits with an employmentId, asserting contract details submit without re-filling the whole form and the flow reaches the benefits step.

Reviewed by Cursor Bugbot for commit 8ac40cf. Bugbot is set up for automated code reviews on this repo. Configure here.

@gabrielseco
gabrielseco marked this pull request as ready for review July 29, 2026 11:29
@gabrielseco gabrielseco self-assigned this Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 250.2 kB 250.2 kB +6 B (+0.0%) 🔴
Total (raw) 670.55 kB 670.55 kB 0 B (0%) 🟢
CSS (gzip) 21.69 kB 21.69 kB 0 B (0%) 🟢
CSS (raw) 112.77 kB 112.77 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 250.2 kB / 350 kB (71.5%)
  • ✅ Total raw: 670.55 kB / 850 kB (78.9%)
  • ✅ CSS gzipped: 21.69 kB / 25 kB (86.8%)

Largest Files (Top 5)

  1. chunk-4FGKIGKF.js - 14 kB (0 B (0%))
  2. styles.css - 10.85 kB (0 B (0%))
  3. index.css - 10.85 kB (0 B (0%))
  4. index.js - 6.67 kB (0 B (0%))
  5. chunk-XI55YG73.js - 6.45 kB (0 B (0%))
View All Files (402 total)
File Size (gzip) Change
chunk-4FGKIGKF.js 14 kB 0 B (0%)
styles.css 10.85 kB 0 B (0%)
index.css 10.85 kB 0 B (0%)
index.js 6.67 kB 0 B (0%)
chunk-XI55YG73.js 6.45 kB 0 B (0%)
chunk-XEUKYCLN.js 6.44 kB 0 B (0%)
chunk-NXRWBI36.js 5.31 kB 0 B (0%)
chunk-ZZHGZWF4.js 4.86 kB new
chunk-KBDRU6SO.js 4.76 kB 0 B (0%)
chunk-PUCT42KD.js 4.16 kB 0 B (0%)

✅ Bundle size check passed

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-7ik6xk5vr-remotecom.vercel.app
Latest Commit:8ac40cf

Deployed with vercel-action

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-ekqa0p3y8-remotecom.vercel.app
Latest Commit:8ac40cf

Deployed with vercel-action

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 85.02% 84.99% +0.03% 🟢
Statements 84.50% 84.47% +0.03% 🟢
Functions 82.99% 82.98% +0.01% 🟢
Branches 76.49% 76.40% +0.09% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 4109 / 4833
  • Coverage: 85.02%
  • Change: +0.03% (3 lines)
Statements Coverage
  • Covered: 4176 / 4942
  • Coverage: 84.50%
  • Change: +0.03% (3 statements)
Functions Coverage
  • Covered: 1103 / 1329
  • Coverage: 82.99%
  • Change: +0.01% (1 functions)
Branches Coverage
  • Covered: 2580 / 3373
  • Coverage: 76.49%
  • Change: +0.09% (3 branches)

✅ Coverage check passed

@gabrielseco
gabrielseco requested a review from cammellos August 3, 2026 08:28
@gabrielseco

Copy link
Copy Markdown
Collaborator Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7e19701. Configure here.

Comment thread src/flows/Onboarding/tests/fixtures/common.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants