docs(onboarding)- add test to make sure submission keeps working - #1206
Open
gabrielseco wants to merge 10 commits into
Open
docs(onboarding)- add test to make sure submission keeps working#1206gabrielseco wants to merge 10 commits into
gabrielseco wants to merge 10 commits into
Conversation
gabrielseco
marked this pull request as ready for review
July 29, 2026 11:29
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (402 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Collaborator
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7e19701. Configure here.
cammellos
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add test to make sure submission works when contract_details are submitted
It recovers data from the server and submits to avoid submitting whole form
Note
Low Risk
Changes are limited to test fixtures and MSW setup; no production onboarding logic is modified.
Overview
Test-only changes that consolidate onboarding MSW mocks and add coverage for France contract-details submission when employment data is loaded from the server.
Shared MSW handlers for POST/PATCH employments, PUT benefit-offers, and currency conversion move from per-suite
beforeEachoverrides intodefaultHandlersinhandlers.ts, so suites likeOnboardingFlow.test.tsxandOnboardingFlowFrance.test.tsxno longer duplicate them.For France, the multi-step test harness now includes the Benefits step, and a new fixture
employmentDefaultResponseFrancesupplies server-backed contract details (including pre-filled annual gross salary). A new test walks basic information → contract details → benefits with anemploymentId, asserting contract details submit without re-filling the whole form and the flow reaches the benefits step.Reviewed by Cursor Bugbot for commit 8ac40cf. Bugbot is set up for automated code reviews on this repo. Configure here.