Chore/go to pnpm - #1179
Open
jordividaller wants to merge 18 commits into
Open
Conversation
Contributor
|
Already up to date 📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (402 total)
✅ Bundle size check passed |
Contributor
|
Already up to date 📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jordividaller
force-pushed
the
chore/go-to-pnpm
branch
from
July 22, 2026 13:00
66db58d to
ffd9b1d
Compare
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Picks up the dependency bumps that landed on main during the migration: postcss 8.5.18 (security), vitest + @vitest/coverage-istanbul 4.1.10, filesize 11.0.22, axios 1.18.1, @playwright/test 1.61.1, @vitejs/plugin-react 6.0.3. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jordividaller
force-pushed
the
chore/go-to-pnpm
branch
from
July 30, 2026 13:47
28ac250 to
efef9e4
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit efef9e4. Configure here.
| // url: 'http://localhost:3000', | ||
| // reuseExistingServer: !process.env.CI, | ||
| // }, | ||
| }); |
There was a problem hiding this comment.
Compiled Playwright config committed
Medium Severity
example/playwright.config.js is compiled output from tsc -b via tsconfig.e2e.json, which includes playwright.config.ts with no noEmit/outDir. The new gitignore only ignores /e2e/**/*.js, so this root emit stays tracked and can drift from the TypeScript source.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit efef9e4. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm → pnpm migration
Straight migration to
pnpm@11.10.0(same version as Dragon). No restructuring: root andexample/stay two independent projects, each with its ownpnpm-lock.yaml.Changes
packageManager: pnpm@11.10.0pinned in both projects (corepack enableonce and you're set).package-lock.json→pnpm-lock.yaml(root + example).npm ci→pnpm install --frozen-lockfile,npm run→pnpm,npx→pnpm exec.npm publish/npm viewkept (registry ops only).example/now consumes the SDK vialink:..— same live symlink behavior asfile:..had under npm.npm installfor consumers).Phantom deps surfaced by pnpm's strict node_modules (now declared)
typescript@6.0.3— required byignoreDeprecations: "6.0"in tsconfiglodash+@types/lodash— imported directly insrc/@remoteoss/json-schema-form— its types leak into our published.d.tsNotes
pnpm-workspace.yamlfiles are settings/root markers only (nopackages:key — not a workspace). They gate dependency build scripts viaallowBuilds.base-coverageandsize-check(base branch is still on npm until this merges) — remove after merge.pnpm run cilocally (plainpnpm ciis pnpm's builtin clean-install).Verified:
pnpm run cigreen (821/821 tests),size:checkgreen, example type-check/build green.Note
Medium Risk
Touches all CI/release paths and install semantics; transitional npm fallbacks and the new root build step for Playwright reduce but don’t eliminate pipeline risk until main is fully on pnpm.
Overview
Migrates the repo from npm to pnpm@11.10.0 (pinned via
packageManagerin root andexample/). Lockfiles switch frompackage-lock.jsontopnpm-lock.yamlin both projects; they remain separate installs, not a shared pnpm workspace.CI/CD and tooling enable Corepack, use
pnpm install --frozen-lockfile --ignore-scripts, and replacenpm run/npxwithpnpm/pnpm execacross workflows (PR, main, release, coverage, size-check, E2E). Size/badge workflows watchpnpm-lock.yamlinstead ofpackage-lock.jsonand usecache: 'pnpm'. Base-branch steps in PR coverage and size-check still fall back to npm whenpnpm-lock.yamlis missing until main has merged.Example app:
@remoteoss/remote-flowsislink:..(replacingfile:..);preinstallusesonly-allow pnpm(skipped on Vercel). E2E/Playwright jobs build the root package before installingexample/so the symlinked SDK’sdist/exists. Docs and.cursor/BUGBOT.mdnow document pnpm commands; consumer-facing README install stays npm where noted.The PR description also lists explicit dependencies pnpm’s strict layout surfaced (
typescript,lodash,@remoteoss/json-schema-form).Reviewed by Cursor Bugbot for commit efef9e4. Bugbot is set up for automated code reviews on this repo. Configure here.