fix(headers): correct windows-1252 test assertion for Node 24.13.1#11085
Closed
mhalikosen wants to merge 1 commit intoremix-run:mainfrom
Closed
fix(headers): correct windows-1252 test assertion for Node 24.13.1#11085mhalikosen wants to merge 1 commit intoremix-run:mainfrom
mhalikosen wants to merge 1 commit intoremix-run:mainfrom
Conversation
Node 24.13.1 introduced proper WHATWG Encoding Standard compliance for windows-1252 (nodejs/node#60893, nodejs/node#61093), correctly mapping byte 0x80 to U+20AC (€). The test assertion was previously changed to expect \x80 as a workaround for the old TextDecoder behavior in fa226ba.
Author
|
CI is running Node v24.13.0 which still has the TextDecoder bug. Tests will pass once the repo's Node version is bumped to v24.13.1+. |
mjackson
added a commit
that referenced
this pull request
Feb 26, 2026
Update engine/docs to Node 25 and align windows-1252 test behavior on Node 25. Closes #11085
Member
|
Fixed in #11087 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "correctly decodes windows-1252 encoded filename" test in
content-disposition.test.tshas been failing on the Windows CI runner since it picked up Node 24.13.1.
The test expects
'file\x80.txt'but receives'file€.txt'. This is because Node 24.13.1introduced proper WHATWG Encoding Standard compliance for windows-1252 via
nodejs/node#60893 and nodejs/node#61093. Under the standard, byte
0x80maps toU+20AC(Euro sign,€), not the C1 control characterU+0080.The assertion originally expected
€but was changed to\x80in fa226ba as aworkaround for the old TextDecoder behavior. This PR reverts the assertion to the
spec-correct value.
The Ubuntu runner still passes because it is on 24.13.0, but it will also fail once
the runner image updates.
Failing CI run: https://github.com/remix-run/remix/actions/runs/22331705571
Test plan
pnpm --filter @remix-run/headers run testpasses locally