build: migrate from mypy to pyright#132
Merged
Merged
Conversation
Replace mypy with pyright as the project's type checker, using strict mode. Changes: 1. **`pyproject.toml`** — Replace `mypy==2.3.0` with `pyright` in `[project.optional-dependencies] lint`. Remove `[tool.mypy]` section and add `[tool.pyright]` with `typeCheckingMode = "strict"` and equivalent excludes. 2. **`.pre-commit-config.yaml`** — Replace the `mirrors-mypy` hook with a pyright pre-commit hook (`RobertCraiworthy/mirrors-pyright` or run via `uv run pyright .`). 3. **`.github/CONTRIBUTING.md`** — Update the "Run type checking" command from `uv run mypy .` to `uv run pyright .`. 4. **`.gitignore`** — Remove mypy-specific entries (`.mypy_cache/`) if present; no pyright cache directory is needed (it uses `node_modules/.pyright` internally, already gitignored by most templates). 5. **Verify** — Run `uv run pyright .` locally to confirm clean output or surface any new errors to address.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 5 5
=========================================
Hits 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
remarkablemark
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace mypy with pyright as the project type checker.
Changes
mypy==2.3.0withpyright==1.1.411in lint dependencies[tool.pyright]withtypeCheckingMode = "strict"[tool.mypy]sectionmirrors-mypyto a local pyright hook