refactor: replace trim() helper with native String.prototype.trim()#557
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 100 97 -3
Branches 17 16 -1
=========================================
- Hits 100 97 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trim() helper with native String.prototype.trim()
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Refactor: remove the polyfill-era
trim()helper function in favor of the nativeString.prototype.trim(), which has been universally available since IE9 and Node.js v0.1.What is the current behavior?
A custom
trim()helper wrapsstr.replace(/^\s+|\s+$/g, '')with a falsy guard, along with a comment referencing the MDN polyfill.What is the new behavior?
The
trim()helper andTRIM_REGEXare removed. Call sites now usestr.replace(COMMENT_REGEX, '').trim()directly.Checklist: