fix: replace COMMENT_REGEX to prevent ReDoS vulnerability#556
Merged
Conversation
- Replace nested quantifier pattern with lazy match to eliminate polynomial backtracking - Fix CodeQL: polynomial regular expression used on uncontrolled data
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 100 100
Branches 17 17
=========================================
Hits 100 100 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Tick the box to add this pull request to the merge queue (same as
|
remarkablemark
changed the title
COMMENT_REGEX to prevent ReDoS vulnerability
- Replace lazy quantifier with mutually exclusive alternatives to eliminate backtracking - Add test cases for adversarial comment inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Bug fix:
COMMENT_REGEXused a nested quantifier pattern that is vulnerable to polynomial backtracking (ReDoS) on adversarial input strings.What is the current behavior?
The pattern
/\/\*[^*]*\*+([^/*][^*]*\*+)*\//ghas nested quantifiers that can cause polynomial backtracking on strings starting with/**with many repetitions of)\/**, triggering a CodeQL high-severity alert: Polynomial regular expression used on uncontrolled data.What is the new behavior?
COMMENT_REGEXis replaced with/\/\*[\s\S]*?\*\//g, a lazy match with no nested quantifiers that eliminates the backtracking risk.Checklist: