fix: parse unquoted url() values containing semicolons#554
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Tick the box to add this pull request to the merge queue (same as
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 100 100
Branches 17 17
=========================================
Hits 100 100 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Extend `VALUE_REGEX` to match `url(...)` as a single token - Handle unquoted data URIs like `url(data:image/png; base64,...)` - Add test case for unquoted data URI with semicolon in `url()`
remarkablemark
force-pushed
the
fix/parser
branch
from
639de3f to
a7b60ad
Compare
remarkablemark
changed the title
url() values containing semicolons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Bug fix: the parser failed to parse unquoted
url()values that contain semicolons, such as data URIs (e.g.url(data:image/png; base64,...)).What is the current behavior?
Parsing
background: url(data:image/png; base64,...)throwsproperty missing ':'becauseVALUE_REGEXstops matching at the;inside the unquotedurl(), treating the remainder as a new property declaration.What is the new behavior?
VALUE_REGEXnow includes aurl(...)alternative that consumes the entire unquotedurl()token (including any;inside it) before falling back to character-by-character matching.Checklist: