fix: parse semicolon and parenthesis inside quoted url#551
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #551 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 103 103
Branches 20 20
=========================================
Hits 103 103 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Bug fix: the parser fails when a quoted
url()contains)and;inside the string, which is common in SVG data URLs.Related to remarkablemark/style-to-object#112
What is the current behavior?
Fixes #550.
inlineStyleParserthrowsproperty missing ':'when parsing a value like:This also affects real-world SVG data URLs that contain nested
url(...)and semicolons in attributes likeanimateTransform values='...;...'.What is the new behavior?
Quoted
url()values are parsed as a single value, including any)or;inside the quotes.Checklist: