-
Notifications
You must be signed in to change notification settings - Fork 1.7k
perf: cut socket-layer per-event overhead (header cache, route LRU, deferred event routing) #6744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alek99
wants to merge
5
commits into
main
Choose a base branch
from
claude/reflex-perf-optimizations-21kg8y-socket
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−39
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bbf451d
perf: cut socket-layer per-event overhead
claude 9a1252b
chore: add news fragments for #6744
claude b1570f1
fix: make background-path state bindings provable for pyright
claude ac961f3
fix: keep delta emit under lock, preserve NaN/Infinity wire tokens
claude 0c8d27e
refactor: drop orjson wire encoder from socket PR
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Reduce per-event websocket overhead: client headers are decoded once per connection instead of per event, route resolution is cached, and chained-event routing no longer runs while holding the state lock. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Event handlers' final chained-event routing now runs after the state lock is released, shortening lock hold time per event; deltas and streamed (yielded) updates still emit immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a foreground handler changes a mutable state var while a background task is waiting on the same state lock, this releases the lock before the deferred
ctx.emit_deltaserializes the delta.BaseState.get_delta()builds the delta withself.get_value(prop), so list/dict values are still the original mutable objects; a background task can acquire the lock and mutate those objects before this deferred emit runs, causing the client to receive the background mutation in the foreground update or out of order. Please either emit/encode while the lock is held or copy/freeze the resolved delta before releasing it.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and fixed in ac961f3 —
get_valuedoes return the live containers, andemit_lost_and_foundawaits redis before pickling, so the window was real on multi-instance deployments. Deltas now emit inline under the lock again (exactly as before this PR); only the routing of final chained events is deferred past the lock, which is safe because event payloads are detached from state at creation time.Generated by Claude Code