Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
29bace4
Initial plan
Copilot Jan 9, 2026
4f5a347
Add script to include example URLs in JSDocs for index.d.ts
Copilot Jan 9, 2026
a6156af
Fix linting issues in add-examples-to-dts.ts script
Copilot Jan 9, 2026
41cf558
Address code review feedback: add tsx as devDependency and improve co…
Copilot Jan 9, 2026
8d74970
Use node --import tsx instead of tsx directly, add as postbuild:types…
Copilot Jan 9, 2026
04a039d
Remove accidentally committed build artifacts (.d.ts files)
Copilot Jan 9, 2026
6bc42f0
Remove tsx, use Node's native TypeScript execution, commit distributi…
Copilot Jan 11, 2026
730d749
Extend existing JSDoc blocks and add validations to add-examples-to-d…
Copilot Jan 12, 2026
4e23b8a
Merge branch 'main' into copilot/include-example-urls-jsdocs
fregante Jan 12, 2026
0513c34
Remove --experimental-strip-types flag and hashbang
Copilot Jan 12, 2026
34ebeb4
Add actions/setup-node with node-version-file to all workflow jobs
Copilot Jan 12, 2026
99b8c15
Discard changes to .github/workflows/esm-lint.yml
fregante Jan 12, 2026
6d38ee7
Discard changes to .github/workflows/demo.yml
fregante Jan 12, 2026
65e3e42
Discard changes to .github/workflows/ci.yml
fregante Jan 12, 2026
f6694e6
Merge branch 'main' into copilot/include-example-urls-jsdocs
fregante Jan 13, 2026
3e9eb42
Add distribution folder back to .gitignore and remove tracked files
Copilot Jan 13, 2026
8a4d8b5
Add actions/setup-node to esm-lint Pack job only
Copilot Jan 13, 2026
05a2e67
Fix build and lint errors for Node 24 compatibility
Copilot Jan 13, 2026
4d8dadc
Revert incorrect changes and properly fix ESLint issues
Copilot Jan 13, 2026
dbbf883
Fix what copilot couldn't
fregante Jan 14, 2026
3853999
Anytime now
fregante Jan 14, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/esm-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version-file: package.json
- run: npm install
- run: npm run build --if-present
- run: npm pack --dry-run
Expand Down
153 changes: 153 additions & 0 deletions add-examples-to-dts.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,153 @@
/* eslint-disable n/prefer-global/process, unicorn/no-process-exit */
import {readFileSync, writeFileSync} from 'node:fs';
import {execSync} from 'node:child_process';
// Import index.ts to populate the test data via side effect
// eslint-disable-next-line import-x/no-unassigned-import
import './index.ts';
import {getTests} from './collector.ts';

// Read the generated .d.ts file
const dtsPath = './distribution/index.d.ts';
const dtsContent = readFileSync(dtsPath, 'utf8');

// Check if script has already been run
const marker = '/* Examples added by add-examples-to-dts.ts */';
if (dtsContent.includes(marker)) {
console.error('❌ Error: Examples have already been added to this file');
process.exit(1);
}

// Process each exported function
const lines = dtsContent.split('\n');
const outputLines: string[] = [];
let examplesAdded = 0;

for (const line of lines) {
// Check if this is a function declaration
const match = /^export declare const (\w+):/.exec(line);
if (match) {
const functionName = match[1];

// Get the tests/examples for this function
const examples = getTests(functionName);

// Only add examples if they exist and aren't the special 'combinedTestOnly' marker
if (examples && examples.length > 0 && examples[0] !== 'combinedTestOnly') {
// Filter to only include actual URLs (not references to other functions)
const urlExamples = examples.filter((url: string) => url.startsWith('http'));

if (urlExamples.length > 0) {
// Check if there's an existing JSDoc block immediately before this line
let jsDocumentEndIndex = -1;
let jsDocumentStartIndex = -1;
let isSingleLineJsDocument = false;

// Look backwards from outputLines to find JSDoc
for (let index = outputLines.length - 1; index >= 0; index--) {
const previousLine = outputLines[index];
const trimmed = previousLine.trim();

if (trimmed === '') {
continue; // Skip empty lines
}

// Check for single-line JSDoc: /** ... */
if (trimmed.startsWith('/**') && trimmed.endsWith('*/') && trimmed.length > 5) {
jsDocumentStartIndex = index;
jsDocumentEndIndex = index;
isSingleLineJsDocument = true;
break;
}

// Check for multi-line JSDoc ending
if (trimmed === '*/') {
jsDocumentEndIndex = index;
// Now find the start of this JSDoc
for (let k = index - 1; k >= 0; k--) {
if (outputLines[k].trim().startsWith('/**')) {
jsDocumentStartIndex = k;
break;
}
}

break;
}

// If we hit a non-JSDoc line, there's no JSDoc block
break;
}

if (jsDocumentStartIndex >= 0 && jsDocumentEndIndex >= 0) {
// Extend existing JSDoc block
if (isSingleLineJsDocument) {
// Convert single-line to multi-line and add examples
const singleLineContent = outputLines[jsDocumentStartIndex];
// Extract the comment text without /** and */
const commentText = singleLineContent.trim().slice(3, -2).trim();

// Replace the single line with multi-line format
outputLines[jsDocumentStartIndex] = '/**';
if (commentText) {
outputLines.splice(jsDocumentStartIndex + 1, 0, ` * ${commentText}`);
}

// Add examples after the existing content
const insertIndex = jsDocumentStartIndex + (commentText ? 2 : 1);
for (const url of urlExamples) {
outputLines.splice(insertIndex + urlExamples.indexOf(url), 0, ` * @example ${url}`);
}

outputLines.splice(insertIndex + urlExamples.length, 0, ' */');
examplesAdded += urlExamples.length;
} else {
// Insert @example lines before the closing */
for (const url of urlExamples) {
outputLines.splice(jsDocumentEndIndex, 0, ` * @example ${url}`);
}

examplesAdded += urlExamples.length;
}
} else {
// Add new JSDoc comment with examples before the declaration
outputLines.push('/**');
for (const url of urlExamples) {
outputLines.push(` * @example ${url}`);
}

outputLines.push(' */');
examplesAdded += urlExamples.length;
}
}
}
}

outputLines.push(line);
}

// Add marker at the beginning
const finalContent = `${marker}\n${outputLines.join('\n')}`;

// Validate that we added some examples
if (examplesAdded === 0) {
console.error('❌ Error: No examples were added. This likely indicates a problem with the script.');
process.exit(1);
}

// Write the modified content back
writeFileSync(dtsPath, finalContent, 'utf8');

console.log(`✓ Added ${examplesAdded} example URLs to index.d.ts`);

// Validate with TypeScript
try {
execSync('npx tsc --noEmit distribution/index.d.ts', {
cwd: process.cwd(),
stdio: 'pipe',
});
console.log('✓ TypeScript validation passed');
} catch (error: unknown) {
console.error('❌ TypeScript validation failed:');
const execError = error as {stdout?: Uint8Array; stderr?: Uint8Array; message?: string};
console.error(execError.stdout?.toString() ?? execError.stderr?.toString() ?? execError.message);
process.exit(1);
}
2 changes: 1 addition & 1 deletion index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import reservedNames from 'github-reserved-names/reserved-names.json' with {type: 'json'};
import {addTests} from './collector.js';
import {addTests} from './collector.ts';

const $ = <E extends Element>(selector: string) => document.querySelector<E>(selector);
const exists = (selector: string) => Boolean($(selector));
Expand Down
13 changes: 5 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
"scripts": {
"build": "run-p build:*",
"build:esbuild": "esbuild index.ts --bundle --external:github-reserved-names --outdir=distribution --format=esm --drop-labels=TEST",
"build:typescript": "tsc --declaration --emitDeclarationOnly",
"build:typescript": "tsc",
"postbuild:typescript": "node add-examples-to-dts.ts",
"build:demo": "vite build demo",
"try": "esbuild index.ts --bundle --global-name=x --format=iife | pbcopy && echo 'Copied to clipboard'",
"fix": "xo --fix",
Expand All @@ -46,6 +47,7 @@
"devDependencies": {
"@sindresorhus/tsconfig": "^8.1.0",
"@sveltejs/vite-plugin-svelte": "^6.2.4",
"@types/node": "^25.0.8",
"esbuild": "^0.27.2",
"globals": "^17.0.0",
"npm-run-all": "^4.1.5",
Expand Down
6 changes: 2 additions & 4 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
{
"extends": "@sindresorhus/tsconfig",
"compilerOptions": {
// TODO: Drop after https://github.com/sindresorhus/tsconfig/issues/29
"resolveJsonModule": true,
"moduleResolution": "Node",
"module": "Preserve"
"emitDeclarationOnly": true,
"allowImportingTsExtensions": true
},
"include": [
"index.ts",
Expand Down