Add replication compression setting#137
Merged
Merged
Conversation
Contributor
Author
|
@reductstore/maintainers @reductstore/devops @atimin ready for review. The SDK/API changes follow the approved plan from #136. I also touched |
atimin
requested changes
Jul 14, 2026
atimin
left a comment
atimin
left a comment
Member
There was a problem hiding this comment.
update CHANGELOG and address my comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature.
What was changed?
IClient::ReplicationCompressionwithkNone,kZstd, andkGzip.ReplicationSettings::compression, defaulting tokNone.compressionfield for create/update requests.null,none,zstd, andgzipcompression values from full replication info.[1_21]integration test for create/get/update compression.latesttest exclusion to skip the new[1_21]server-main-only test.kNoneis omitted on write to preserve compatibility with older ReductStore servers while still behaving as the API default.Related issues
Does this PR introduce a breaking change?
No. Existing callers that omit
compressioncontinue to compile and use the defaultnonebehavior. Older server responses withoutsettings.compressionparse askNone.Other information:
Local validation:
find src/ \( -name "*.cc" -o -name "*.h" \) -print0 | xargs -0 cpplintfind tests/ \( -name "*.cc" -o -name "*.h" \) -print0 | xargs -0 cpplintfind examples/ \( -name "*.cc" -o -name "*.h" \) -print0 | xargs -0 cpplintcmake -S . -B build -DREDUCT_CPP_USE_FETCHCONTENT=ON -DREDUCT_CPP_ENABLE_TESTS=ONcmake --build buildREDUCT_CPP_TOKEN_API=TOKEN ./build/bin/reduct-testsagainstreduct/store:mainwithRS_API_TOKEN=TOKEN,RS_AUDIT_ENABLED=false,RS_SYSTEM_EVENTS_ENABLED=falseREDUCT_CPP_TOKEN_API=TOKEN ./build/bin/reduct-tests "~[1_21]"againstreduct/store:latestwith the same server env./build/bin/reduct-tests "~[token_api]" -r compactagainst unauthenticatedreduct/store:main./build/bin/reduct-tests "~[token_api]~[1_21]" -r compactagainst unauthenticatedreduct/store:latest