-
Notifications
You must be signed in to change notification settings - Fork 7
Change product switcher to neutral background with colored icon chip #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2849b47
Change product switcher to neutral background with colored icon chip
JakeSCahill a8d0830
Add icons to product switcher chips
JakeSCahill d4757e2
Fix nav collapse toggle visibility on mobile
JakeSCahill dcf602e
Fix missing space before 'Let us know' link in search results
JakeSCahill 049f720
Fix back-to-top button overlapping pagination Next button
JakeSCahill 13ae8e6
Remove icons from dropdown menu chips, keep color-only
JakeSCahill 535b13e
Add margin-left to cloud link icon
JakeSCahill 50f9556
Change ADP icon from brain to sparkles
JakeSCahill 18631e5
Add ADP-specific condition to show sparkles icon
JakeSCahill d372ba3
Add missing parent components to preview UI model
JakeSCahill 2784411
Match platform indicator font size to nav items
JakeSCahill a47db72
Fix SVG sizing for dropdown product chips
JakeSCahill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropdown icon SVG size conflicts with chip sizes
.sb-product-chip svg { width: 16px; height: 16px; }applies globally, but dropdown chips are still10/8/6pxin this file, so many new SVGs will clip or become unreadable in menu options.Suggested CSS fix
.sb-product-chip svg { width: 16px; height: 16px; color: `#fff`; } + +/* Keep dropdown SVGs proportional to smaller chip containers */ +.sb-product-opt .sb-product-chip svg { + width: 8px; + height: 8px; +} + +.sb-product-opt.sb-product-child .sb-product-chip svg { + width: 6px; + height: 6px; +} + +.sb-product-opt.sb-product-grandchild .sb-product-chip svg { + width: 5px; + height: 5px; +}📝 Committable suggestion
🤖 Prompt for AI Agents