feat(consumers): migrate consumer groups to UI Registry by jvorcak · Pull Request #2545 · redpanda-data/console

jvorcak · 2026-06-30T16:32:02Z

Summary

Migrates the consumer groups feature (list, detail, and the edit/delete offset modals) from the legacy @redpanda-data/ui components to the Registry components — matching the already-migrated Topics/Security pages.

List (`group-list.tsx`)

Hand-rolled TanStack useReactTable + Registry Table inside ListLayout
URL-persisted page / pageSize / sort / search (nuqs), sortable columns, pagination
State faceted filter (all states always available, even when not present in the data)
New useLegacyListConsumerGroupsFullQuery hook returning enriched GroupDescription (lagSum/isInUse/perms)

Detail (`group-details.tsx`)

Registry Tabs (Topics / ACL, active tab persisted in the URL), Card stats bar, Accordion per topic, sortable + paginated PartitionTable
Disabled Edit/Delete Group buttons now show an explanatory tooltip ("Offsets can only be edited while the group is Empty with no connected members.")
Shared ConsumerGroupStateCell (icon + state) reused by both list and detail

Modals (`modals.tsx`)

DeleteOffsetsModal → Registry AlertDialog
EditOffsetsModal → Registry Dialog / Select / RadioGroup / Input / Accordion + useReactTable preview tables; toasts moved to sonner. KowlTimePicker kept (no Registry datetime picker yet).
modals.tsx no longer imports @redpanda-data/ui at all.

Test plan

bun run type:check — pass
bun run lint — pass
bun run test:integration — all consumer-group tests pass (group-details 2/2); full suite green apart from one unrelated flaky observability-page test that passes in isolation
Manual: list sorting/pagination/filter + URL persistence; detail tabs/accordion/partition table; delete + edit offset flows against an Empty group

🤖 Generated with Claude Code

Migrate the consumer groups list, detail page, and the edit/delete offset modals from legacy @redpanda-data/ui to the Registry components. List (group-list.tsx): - TanStack useReactTable + Registry Table inside ListLayout - URL-persisted page/pageSize/sort/search (nuqs), sortable columns, pagination, and a State faceted filter (all states always available) - New useLegacyListConsumerGroupsFullQuery hook (Connect/REST) returning enriched GroupDescription (lagSum/isInUse/perms) Detail (group-details.tsx): - Registry Tabs (Topics/ACL, tab persisted in URL), Card stats bar, Accordion per topic, and a sortable+paginated PartitionTable - Disabled Edit/Delete buttons now show an explanatory tooltip - Shared ConsumerGroupStateCell (icon + state) reused by list and detail Modals (modals.tsx): - DeleteOffsetsModal -> Registry AlertDialog - EditOffsetsModal -> Registry Dialog/Select/RadioGroup/Input/Accordion + useReactTable preview tables; toasts moved to sonner - KowlTimePicker kept (no Registry datetime picker yet) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions · 2026-06-30T16:33:53Z

🚨 Registry drift detected

App: frontend · Scope: diff vs origin/master · Files: 12

	Count
⚠️ Outdated registry components	1
🛠 Locally-modified components	0
❓ Unknown to registry	0
🎨 Off-token palette colours	0
🔢 Ad-hoc utility classes	0

Components needing attention

Status	Component	Uses	Detail
⚠️ outdated	`stat`	2×	installed `2.4.1` → latest `2.6.0`

Refresh command:

bunx shadcn@latest add @redpanda/stat --overwrite

Generated by lookout audit-changes.

base-ui SelectValue renders the raw selected value, so the "All Topics/Partitions" sentinel ('__all__') and the strategy keys (endOffset, ...) leaked into the trigger. Map value -> label via a SelectValue render function, matching the add-acl-dialog pattern. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Empty groups have no protocol/protocolType, which rendered blank stat values, and the legacy ProtocolType helper duplicated protocolType under a "Protocol" label. Show the actual group.protocol field (matching the list column) and group.protocolType with an em-dash fallback, and drop the redundant ProtocolType component. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

The Coordinator ID copy button used size="icon" (size-9, 36px), which was much taller than the stat label text; the flex row stretched every stat to that height, inflating the card and leaving gaps under the other labels. Shrink the copy button to size-5 and add items-start so the row hugs its natural content height. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

The migrated partition action buttons use the registry (base-ui) tooltip, which renders a `[data-slot="tooltip-content"]` popup without role="tooltip" (the old Chakra tooltip had it). Match on the slot + text instead of getByRole('tooltip'). No app code changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Local e2e runs remap every host port via E2E_PORTS_OVERRIDE, but the enterprise config hardcoded shadowBackendURL to http://localhost:3101, so the shadowlink tests hit ERR_CONNECTION_REFUSED (the dest backend was on a random port). Resolve the shadow backend port from the override (falling back to 3101 for CI/static-port runs). No app code changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Move DisabledReasonButton out of group-details.tsx into src/components/ui/ so it can be reused outside consumer group details. Behavior unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Two layout fixes surfaced by the group list page: - group-list rendered its table inside ListLayoutContent (flex-1), which grew to fill the min-h-screen layout and pushed the pagination bar to the bottom of the viewport. Render <Table> directly like the other list pages so pagination sits under the last row. - ListLayoutPagination did not stretch its child, so DataTablePagination collapsed to content width and its internal justify-between clustered the controls on the left. Add [&>*]:w-full so the controls span the row (also fixes topics/quotas/users/roles list pages). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…y drift The pagination full-width fix edited the vendored list-layout registry component in-place, which the UI audit flags as locally-modified drift. Revert list-layout to its released bytes and apply [&>*]:w-full via className at the ListLayoutPagination call site instead — same render, no registry drift. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Console's dialog and tabs were pinned to registry 2.3.0's predecessor (2.2.0), which the frontend UI audit flags as outdated once the consumer pages use them. Sync both to the 2.3.0 release: - dialog: scroll-shadow refactor — useScrollShadow now takes the container ref and returns axis-relative { start, end } edges (was sentinel refs + { top, bottom }). - use-scroll-shadow: rewritten to the 2.3.0 geometry-based API (scroll + ResizeObserver/MutationObserver, horizontal orientation support). Only caller in console is DialogBody; rp-connect only mentions it in a comment. - tabs: add ScrollableTabsList, pulling in the new drag-scroll-area dep. - drag-scroll-area: new component from 2.3.0. Audit now reports dialog + tabs up-to-date at 2.3.0; 0 drift. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

malinskibeniamin · 2026-07-13T10:25:03Z

+      // Registry (base-ui) tooltip renders a `[data-slot="tooltip-content"]` popup
+      // without role="tooltip", so match on the slot + text instead of the role.


sounds like we should fix this so we can have simpler test assertions to write

Base UI's tooltip popup sets no ARIA role, so the disabled-action tooltip was only reachable via a [data-slot] selector. Set role="tooltip" at the call site (keeping the registry component free of drift) so it is exposed as a tooltip to assistive tech and to getByRole in tests. Derive the button variant/size props from the registry ButtonProps so they cannot drift from the Button they are forwarded to. Drop the per-assertion timeouts in the e2e spec: the Playwright config already sets a 60s expect timeout, so they were only shortening the default. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

The tooltip reads "No committed offsets" (plural). Switching the assertion from a substring filter to toHaveText made the exact text matter, so the singular string no longer matched and the test timed out. Pull the string into a constant so it stays tied to group-details.tsx. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Adopt the registry Stat component for the group list and detail stats bars, replacing the hand-rolled label/value stacks. Swap both search fields to registry Input + InputStart/InputEnd so the padding and icon positioning come from the component instead of ad-hoc absolute positioning, and associate the "topics with lag" checkbox with a registry Label via htmlFor. Drop the activeClassName="after:bg-foreground" override on the tabs so the underline uses the registry's intended after:bg-selected, and remove the hover:bg-transparent override on the empty-state row: TableRow has no hover background, only data-[state=selected], which this row never gets. Hoist the column meta type out of render into a shared module, derived from the registry's tableHeadVariants so it cannot drift, and compose the disabled trigger in DisabledReasonButton from buttonVariants rather than hardcoding h-8 w-8. stat.tsx is vendored from ui-registry v2.3.0 to match the tagged release the audit classifies against. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…er-groups-to-ui-registry # Conflicts: # frontend/src/routes/groups/$groupId.tsx

SpicyPete · 2026-07-20T15:51:19Z

@@ -0,0 +1,171 @@
+import { cva, type VariantProps } from 'class-variance-authority';


Minor: Registry has a newer version of stat, lets re-pull this in

…elements

SpicyPete · 2026-07-28T14:57:41Z

This PR is becoming a bit stale, can it be rebased + fix the lint errors and I'll take another look at it

The merge from master clobbered GroupList's return JSX with a leftover fragment from master's old GroupId helper (undefined protocol/groupIdEl refs), and an earlier "remove console ai features" cleanup deleted the whole react-query/api/consumer-group.tsx file instead of just the AI-only export, taking useLegacyListConsumerGroupsFullQuery with it. Restore the pre-merge return statement (ListLayout/Stat/filters/table/ pagination) and re-add useLegacyListConsumerGroupsFullQuery.

jvorcak and others added 6 commits June 30, 2026 21:15

refactor(consumers): extract DisabledReasonButton to shared ui

06f67b7

Move DisabledReasonButton out of group-details.tsx into src/components/ui/ so it can be reused outside consumer group details. Behavior unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

jvorcak requested a review from a team July 1, 2026 08:05

jvorcak and others added 3 commits July 1, 2026 10:51

malinskibeniamin reviewed Jul 13, 2026

View reviewed changes

Comment thread frontend/tests/test-variant-console/consumers/consumer-group-unconsumed-partitions.spec.ts Outdated

malinskibeniamin reviewed Jul 13, 2026

View reviewed changes

Comment thread frontend/src/react-query/api/consumer-group.tsx

malinskibeniamin reviewed Jul 13, 2026

View reviewed changes

Comment thread frontend/src/components/ui/disabled-reason-button.tsx Outdated

malinskibeniamin reviewed Jul 13, 2026

View reviewed changes

Comment thread frontend/src/components/redpanda-ui/components/dialog.tsx

jvorcak requested a review from malinskibeniamin July 13, 2026 11:19

jvorcak and others added 2 commits July 13, 2026 13:26

Merge branch 'master' into UX-1371-move-consumer-groups-to-ui-registry

5b0f131