backend: upgrade dependencies to fix Snyk security vulnerabilities#2278
backend: upgrade dependencies to fix Snyk security vulnerabilities#2278
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- Taskfile GO_VERSION now reads from backend/go.mod instead of being hardcoded, so it stays in sync automatically. - install-go task symlinks to the system Go when it already matches the required version, avoiding a redundant download in CI where actions/setup-go has already installed the right version.
| - mkdir -p '{{.GO_BUILD_ROOT}}' | ||
| - curl -sSLf --retry 3 --retry-connrefused --retry-delay 2 '{{.GOLANG_URL}}' | tar -xz -C '{{.GO_BUILD_ROOT}}' --strip 1 | ||
| - | | ||
| # If system Go is already the right version, symlink it instead of downloading |
There was a problem hiding this comment.
This is to try improve ci performance instead of downloading twice which is what we currently do
|
@claude review check if any other security issues/concerns are there. |
|
Claude finished @malinskibeniamin's task in 2m 12s —— View job Security Review
The PR correctly addresses all identified Snyk vulnerabilities and What's Well Done
Additional Concerns Worth Noting1. This indirect dependency was not bumped as part of this PR. The stdlib 2. This Kerberos library is actively used for Kafka SASL/GSSAPI ( 3. GitHub Actions using floating version tags ( - uses: aws-actions/configure-aws-credentials@v4 # ← floating tag
- uses: aws-actions/aws-secretsmanager-get-secrets@v2 # ← floating tagThe 4. curl -sSfL https://raw.githubusercontent.com/.../install.sh | sh -s -- ...This downloads and executes a shell script without checksum verification. It is a common pattern for dev tooling but is a supply chain risk. The new SummaryNo blocking security issues introduced by this PR. The two items worth addressing separately are pinning the AWS GitHub Actions to commit SHAs (item 3 above) and monitoring |
Summary
godirective from 1.26.0 to 1.26.1 to fix std library vulns (crypto/x509, os, net/url, html/template)golang.org/x/netv0.50.0 → v0.51.0github.com/go-git/go-git/v5v5.16.5 → v5.17.0github.com/go-viper/mapstructure/v2v2.4.0 → v2.5.0github.com/golang-jwt/jwt/v5v5.3.0 → v5.3.1Test plan
go build ./...passesgovulncheck ./...reports 0 vulnerabilities