-
Notifications
You must be signed in to change notification settings - Fork 415
feat: add react-doctor #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: add react-doctor #2253
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
530535e
feat: add react-doctor for frontend React performance analysis
malinskibeniamin b910225
frontend: fix some react doctor issues
malinskibeniamin c372b24
frontend: apply PR feedback
malinskibeniamin 20e2de6
frontend: fix react-doctor errors in topic-produce
malinskibeniamin a34ce0f
frontend: react-doctor config and reduced-motion CSS
malinskibeniamin 635b413
frontend: phase 1 mechanical react-doctor fixes
malinskibeniamin e5ba0ac
frontend: fix React Compiler errors (immutability, hooks, refs, memoi…
malinskibeniamin 6c3b312
frontend: fix try/catch value blocks and immutability compiler errors
malinskibeniamin 14ad852
frontend: refactor payload-component and fix ref write pattern
malinskibeniamin 9e348bf
frontend: align react-doctor config with cloudv2 PR #24811
malinskibeniamin 9047023
frontend: fix payload-component type error in json render data
malinskibeniamin dfb2b5b
frontend: add use-no-memo directives and React Compiler source filter
malinskibeniamin 22e4db9
frontend: fix Phase 3 warnings (a11y, array-keys, async-parallel)
malinskibeniamin 1d92073
frontend: fix array-index-as-key in principal-group-editor
malinskibeniamin 16dcb15
ci: update react-doctor workflow fail-on to warning level
malinskibeniamin 273db6b
ci: use bun run doctor instead of millionco GitHub Action
malinskibeniamin fe913a0
frontend: ignore React Compiler rules in react-doctor config
malinskibeniamin 0a35200
frontend: fix remaining no-array-index-as-key warnings for 100/100 re…
malinskibeniamin aaa45ae
frontend: enable react-hooks/rules-of-hooks in react-doctor
malinskibeniamin 4db841b
ci: align react-doctor workflow with cloudv2 pattern
malinskibeniamin 1d344f4
frontend: add diff: false to react-doctor config
malinskibeniamin c511c4b
frontend: enable react-hooks-js/error-boundaries and preserve-manual-…
malinskibeniamin 8a2b6e6
frontend: enable react-doctor/no-prevent-default rule
malinskibeniamin 8eca4b9
frontend: enable react-doctor/no-derived-useState rule
malinskibeniamin 7bc8bcc
frontend: enable react-hooks-js/static-components rule
malinskibeniamin 3454947
frontend: enable react-hooks-js/purity rule
malinskibeniamin aa19030
frontend: enable react-hooks-js/hooks rule
malinskibeniamin 2a739e6
frontend: enable react-hooks-js/immutability rule
malinskibeniamin d2a138b
frontend: enable react-doctor/no-effect-event-handler rule
malinskibeniamin b6bfb96
frontend: enable react-doctor/no-cascading-set-state rule
malinskibeniamin 3382858
frontend: enable react-hooks-js/todo rule
malinskibeniamin 7559561
frontend: enable react-hooks-js/refs rule
malinskibeniamin 4403e03
frontend: enable react-hooks-js/set-state-in-effect rule
malinskibeniamin 3479763
frontend: enable react-hooks-js/incompatible-library rule
malinskibeniamin 981d33d
frontend: enable react-doctor/prefer-dynamic-import rule
malinskibeniamin 33b8acc
frontend: enable react-doctor/prefer-useReducer rule
malinskibeniamin 0990b57
frontend: enable react-doctor/no-render-in-render rule
malinskibeniamin f0d363b
frontend: fix react-doctor regressions from type-fix agent
malinskibeniamin 4d9e6b9
frontend: fix type errors
malinskibeniamin af8878b
frontend: fix useApiStore type errors with useApiStoreHook wrapper
malinskibeniamin 0c86164
frontend: restore useStore import in backend-api.ts
malinskibeniamin cccdb3c
frontend: fix useApiStoreHook selector type to match raw store state
malinskibeniamin 9d2dcf7
frontend: enable knowledgebase files in react-doctor config
malinskibeniamin 7a7657a
frontend: enable agents list page in react-doctor config
malinskibeniamin 192202b
frontend: enable mcp-servers list page in react-doctor config
malinskibeniamin ab0d891
frontend: enable secrets-store list page in react-doctor config
malinskibeniamin a38670e
frontend: enable observability metric-chart in react-doctor config
malinskibeniamin d2595fd
frontend: enable transcripts table in react-doctor config
malinskibeniamin 7db49e2
ci: remove pull_request trigger from react-doctor workflow
malinskibeniamin 16b26d0
frontend: ignore prefer-dynamic-import rule in react-doctor config
malinskibeniamin 074c3cd
ci: remove reviewdog frontend review workflow
malinskibeniamin 0378f14
frontend: enable shadowlinks files in react-doctor config
malinskibeniamin 999ef9f
frontend: enable remaining files in react-doctor config
malinskibeniamin 9fd505a
frontend: fix react-doctor warnings for 100/100 score
malinskibeniamin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "diff": false, | ||
| "deadCode": false, | ||
| "ignore": { | ||
| "files": [ | ||
| "src/components/ui/**", | ||
| "src/components/redpanda-ui/**", | ||
| "src/components/ai-elements/**", | ||
| "src/hooks/use-mobile.ts", | ||
| "src/globals.css", | ||
| "src/components/pages/connect/dynamic-ui/components.tsx" | ||
| ], | ||
| "rules": ["react-doctor/use-lazy-motion", "react-doctor/no-giant-component", "react-doctor/require-reduced-motion", "react-hooks-js/incompatible-library", "react-doctor/prefer-useReducer", "react-doctor/prefer-dynamic-import"] | ||
|
malinskibeniamin marked this conversation as resolved.
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 maybe even
checkor something we'd definitely remember before committing?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have "check" used across various repos for other purposes.
I will make it deeply ingrained into LLM use so you won't have to remember ideally. Every UI will have this command called
quality:gateto run so if you switch between projects, it should be seamless