Skip to content

SQL: monitoring#602

Open
kbatuigas wants to merge 2 commits into
mainfrom
DOC-2197-sql-monitoring
Open

SQL: monitoring#602
kbatuigas wants to merge 2 commits into
mainfrom
DOC-2197-sql-monitoring

Conversation

@kbatuigas
Copy link
Copy Markdown
Contributor

@kbatuigas kbatuigas commented May 29, 2026

Description

This pull request introduces documentation for monitoring Redpanda SQL using Prometheus metrics, and updates navigation and playbook configuration to include the new content. The main focus is to help users identify and query Redpanda SQL metrics for operational monitoring.

New documentation for monitoring Redpanda SQL:

  • Added a new guide, monitor-sql.adoc, detailing how to scrape and interpret Prometheus metrics from the Redpanda SQL engine, including example PromQL queries for node health, query throughput, errors, latency, admission control, and resource usage.

Navigation and configuration updates:

  • Added a link to the new "Monitor Redpanda SQL" page in the SQL management section of the navigation (nav.adoc).
  • Updated the Antora playbook (local-antora-playbook.yml) to reference the correct documentation branch for Redpanda SQL monitoring.

Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:

Page previews

https://deploy-preview-602--rp-cloud.netlify.app/cloud-data-platform/sql/manage/monitor-sql/
https://deploy-preview-602--rp-cloud.netlify.app/cloud-data-platform/reference/public-metrics-reference/#redpanda-sql-metrics

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

kbatuigas and others added 2 commits May 28, 2026 19:52
New how-to page covering where SQL metrics appear and useful PromQL
queries for node health, throughput, latency, admission control, and
resource use. Nav-wired under Manage Redpanda SQL.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 29, 2026

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit 8dd65a9
🔍 Latest deploy log https://app.netlify.com/projects/rp-cloud/deploys/6a1905e453649e00086cc703
😎 Deploy Preview https://deploy-preview-602--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a new "Monitor Redpanda SQL" documentation page that guides operators through monitoring Redpanda SQL using Prometheus/OpenMetrics metrics. The new page explains metric exposure via the /api/cloud/prometheus/public_metrics endpoint and provides PromQL query examples for common monitoring scenarios. The page is integrated into the SQL documentation navigation under "Manage Redpanda SQL," and the local Antora preview configuration is updated to include the feature branch for local documentation builds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • micheleRP
  • nicolaferraro
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'SQL: monitoring' directly reflects the main change—adding SQL monitoring documentation with Prometheus metrics guidance and related configuration updates.
Description check ✅ Passed The description follows the template structure with comprehensive information about the changes, page previews, and checked boxes; however, the issue number placeholder remains unfilled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch DOC-2197-sql-monitoring

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread local-antora-playbook.yml
branches: HEAD
- url: https://github.com/redpanda-data/documentation
branches: [main, v/*, shared, site-search]
branches: ['DOC-2197-sql-monitoring', v/*, shared, site-search]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
branches: ['DOC-2197-sql-monitoring', v/*, shared, site-search]
branches: [main, v/*, shared, site-search]

commit before merge

@kbatuigas kbatuigas marked this pull request as ready for review May 29, 2026 15:39
@kbatuigas kbatuigas requested a review from a team as a code owner May 29, 2026 15:39
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
local-antora-playbook.yml (1)

18-18: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use only allowed branch patterns in playbook sources.

Line 18 introduces a non-standard branch (DOC-2197-sql-monitoring) that violates the branch checker and fails CI. Replace it with the allowed set (for example include main plus the existing allowed patterns) so local preview config passes validation.

Suggested fix
-    branches: ['DOC-2197-sql-monitoring', v/*, shared, site-search]
+    branches: [main, v/*, shared, site-search]
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@local-antora-playbook.yml` at line 18, The branches entry under the playbook
sources uses a non-allowed literal branch name; update the branches array (the
branches: [...] key) to only use allowed patterns (e.g., include "main" and the
existing allowed patterns) so CI branch-check passes—replace the literal
'DOC-2197-sql-monitoring' entry with "main" (keeping v/*, shared, site-search)
in the branches list.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@local-antora-playbook.yml`:
- Line 18: The branches entry under the playbook sources uses a non-allowed
literal branch name; update the branches array (the branches: [...] key) to only
use allowed patterns (e.g., include "main" and the existing allowed patterns) so
CI branch-check passes—replace the literal 'DOC-2197-sql-monitoring' entry with
"main" (keeping v/*, shared, site-search) in the branches list.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 295e84af-de3d-4012-bcd3-b26e47fe5fcf

📥 Commits

Reviewing files that changed from the base of the PR and between f1a7002 and 8dd65a9.

📒 Files selected for processing (3)
  • local-antora-playbook.yml
  • modules/ROOT/nav.adoc
  • modules/sql/pages/manage/monitor-sql.adoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant