updates for 0.6.0#621
Merged
Merged
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
rbs333
force-pushed
the
feat/sql-redis-0.6.0-regression-tests
branch
from
d668cb9 to
c4853e1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s optional sql-redis integration to align with sql-redis v0.6.0, refreshing dependency constraints and adjusting integration tests to validate the fixed query semantics.
Changes:
- Bump
sql-redisoptional dependency floor from>=0.4.0to>=0.6.0(includingallextra). - Refresh
uv.lockto resolvesql-redis==0.6.0. - Update SQL integration tests (remove
xfailfor numericIN; add a regression suite covering v0.6.0 fixes).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Raises the sql-redis optional dependency minimum version to 0.6.0. |
uv.lock |
Updates locked dependencies to include sql-redis 0.6.0 and related resolution changes. |
tests/integration/test_sql_redis_hash.py |
Removes xfail for numeric IN and adds new end-to-end regression tests for sql-redis 0.6.0 behaviors. |
tests/integration/test_sql_redis_json.py |
Removes xfail for numeric IN now that sql-redis supports it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1590
to
+1595
| """Regression tests for the 10 trial-user findings fixed in sql-redis 0.6.0. | ||
|
|
||
| Each test exercises one of the defects end-to-end through SQLQuery + | ||
| SearchIndex. Assertions are behavior-only (result-set membership or | ||
| ValueError on inputs that previously emitted garbage queries) so they | ||
| do not depend on the exact RediSearch query-string formatting. |
tylerhutcherson
approved these changes
May 27, 2026
Comment on lines
59
to
64
| sql-redis = [ | ||
| "sql-redis>=0.5.0", | ||
| "sql-redis>=0.6.0", | ||
| ] | ||
| all = [ | ||
| "mistralai>=1.0.0", | ||
| "mistralai>=1.0.0,<2", | ||
| "openai>=1.1.0", |
Comment on lines
+1637
to
+1639
| def test_not_equals_on_tag_is_negated(self, sql_index): | ||
| """Case 3 (TAG side): NOT category = 'electronics' must exclude electronics.""" | ||
| results = sql_index.query( |
|
🚀 PR was released in |
applied-ai-release-bot
Bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes open customer feedback address with latest release https://github.com/redis-developer/sql-redis/releases/tag/v0.6.0
Note
Low Risk
Changes are dependency pins, broader error-string matching in MCP, and test coverage; no core query or runtime logic beyond MCP index detection.
Overview
This PR aligns redisvl with sql-redis 0.6.0 and locks related optional deps:
sql-redisis raised from>=0.5.0to>=0.6.0(including theallextra), and mistralai is capped at<2in bothmistralaiandallextras.MCP startup now treats more RediSearch “missing index” error strings as absent indexes (
search_index_not_found,index not found), so misconfigured index names fail with a clear error across RediSearch versions.Tests drop the
xfailon numericINin hash and JSON SQL integration suites, and addTestSQLRedis060Regressionon hash storage—end-to-end coverage for ten customer-reported sql-redis fixes (negated filters, tag pipes, numericIN, invalidLIKE/BETWEEN, double-quoted literals,DISTINCT, multi-columnORDER BY).Reviewed by Cursor Bugbot for commit 3687385. Bugbot is set up for automated code reviews on this repo. Configure here.