fix(client): expose MEMORY STATS fields added in Redis 7.4 - #3416
Open
abhijeet117 wants to merge 1 commit into
Open
fix(client): expose MEMORY STATS fields added in Redis 7.4#3416abhijeet117 wants to merge 1 commit into
abhijeet117 wants to merge 1 commit into
Conversation
Contributor
|
@abhijeet117 Thanks for the PR. We’ll review it when we have capacity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redis 7.4 added four top-level fields to MEMORY STATS: overhead.db.hashtable.lut, overhead.db.hashtable.rehashing, db.dict.rehashing.count and allocator.muzzy (object.c emits each via addReplyBulkCString + addReplyLongLong). MemoryStatsReply did not declare them, so consumers needed casts to reach these values. They are now typed as numbers in server reply order, following the existing added-in comments convention.
Testing
Compile-time regression test indexes all four fields on the client-facing reply type; it fails on master with TS7053 and passes after the fix. Verified against Redis 7.4 source; parser spec, type tests, build and lint run locally; Docker-backed integration tests run in CI.
Checklist